Destructing an object

Question

Hi I have this main test code { Firm f = new Firm(0.3f); Consumer c = new Consumer(1f); Console.WriteLine(First Test {0}(c.isNull() ? FAIL : OK)); f = null; GC.Collect(); GC.WaitForPendingFinalizers(); Console.WriteLine(Second Test {0}(c.isNull() ? OK : FAIL)); } The Consumer constructor do this... public Consumer(int pId Firm pFirm) { Id = pId; myFirm = new Firm(0f); myFirm = pFirm; } where myFirm is defined as private Firm myFirm; and the isNull() method is like this public bool isNull() { return (myFirm==null); } When I run the test... y obtain First Test OK Second Test FAIL Can anyone explain to me why the second test Fail? I understand (well I think so) that the object f is passed to the constructor by reference. Thanks in advance!!!!

david 0 · Answer

The results are exactly as expected. At the point where you are calling invoking the collect there are no active [rooted] references to either f or c. So they can both be destroyed. But wait you say I have a local reference to c still in scope!!!! It does not matter you do not refernence the object after that point so the compiler is allowed to eliminate it. Put a method call to the c object AFTER the writeline's and watch what happens. Managed Code is as much of a paradigm shift from C++ as C++ was from C over 12 years ago. Those who bring with them the old ideas and practices are going to suffer the same problems.....

netgesid · Answer

Thanks Kovan for your suggestion. I called the garbage collector just to see whether collecting it explicitly I would solve the problem. However no matter whether I call or not the GC the second test FAIL. Any clue?

kovan · Answer

you should not be destroying the objects urself you should not call the garbage collector you should let the garbage collector take care of it all for you (as long as you properly call the .close methods on certain objects GC will do the rest for u)