Different approach for a repetitive task

Question

I'm looking for an alternative towards a process that takes too much code and generates significant overhead... This code fills in a Chartview (LineChart) and in order to display the progression of 6 different Areas it runs a query 6 times and add the series 6 times... public static void FillLineChart(ChartView chartView CheckedDropDownList checkedDropDown string dateFrom string dateTo) { foreach (var i in checkedDropDown.CheckedItems) { var iindex = i.RowIndex + 1; if (iindex == 1) { LineSeries crime = new LineSeries(); FunctionsDAL cr = new FunctionsDAL(); foreach (var caseType in cr.ListCases(1 dateFrom dateTo)) { crime.DataPoints.Add( new CategoricalDataPoint(caseType.IncrementalTotal CultureInfo.CurrentCulture.DateTimeFormat.GetMonthName(caseType.MonthNum))); } chartView.Series.Add(crime); crime.LegendTitle = Crime ; crime.Spline = true ; } else if (iindex == 2) { } else if (iindex == 3) { } // The same 3 more times } } How could I shorten up this process? or is this the way is supposed to be working? Regards.

Optimus Vulgaris · Answer

I just managed to reduce the code to a few lines: public static void Test(RadChartViewchartViewRadCheckedDropDownListcheckedDropDown string dateFrom string dateTo) { foreach (vari in checkedDropDown.CheckedItems) { LineSerieslineSeries= new LineSeries(); foreach (varcaseType in FunctionsDAL.AmountsPerCase(i.Index+1dateFromdateTo)) { lineSeries.DataPoints.Add( new CategoricalDataPoint(caseType.IncrementalTotalCultureInfo.CurrentCulture.DateTimeFormat.GetMonthName(caseType.MonthNum))); } chartView.Series.Add(lineSeries); lineSeries.LegendTitle=i.ToString(); lineSeries.Spline= true ; } }

theLizard · Answer

The only thing that is different that I see is the LegendTitle in this case you could instead of using foreach you could use a for loop but this would depend on the consistency of your iindex ( var iindex = i.RowIndex + 1;) string[] title = new string[] { Crime Social Civil }; for (int i = 0; i { LineSeriescrime = newLineSeries(); FunctionsDALcr = newFunctionsDAL(); foreach (varcaseTypeincr.ListCases(1dateFromdateTo)) { crime.DataPoints.Add(newCategoricalDataPoint(caseType.IncrementalTotal CultureInfo.CurrentCulture.DateTimeFormat.GetMonthName(caseType.MonthNum))); } chartView.Series.Add(crime); crime.LegendTitle = titil[i]; crime.Spline = true; } This approach would eliminate any else if you have.

Optimus Vulgaris · Answer

Well its just exactly the same: foreach (variincheckedDropDown.CheckedItems) { variindex=i.RowIndex+1; if (iindex==1) { LineSeriescrime=newLineSeries(); FunctionsDALcr=newFunctionsDAL(); foreach (varcaseTypeincr.ListCases(1dateFromdateTo)) { crime.DataPoints.Add(newCategoricalDataPoint(caseType.IncrementalTotal CultureInfo.CurrentCulture.DateTimeFormat.GetMonthName(caseType.MonthNum))); } chartView.Series.Add(crime); crime.LegendTitle= Crime ; crime.Spline= true ; } elseif(iindex==2) { LineSeriessocial=newLineSeries(); FunctionsDALso=newFunctionsDAL(); foreach (varcaseTypeinso.ListCases(1dateFromdateTo)) { social.DataPoints.Add(newCategoricalDataPoint(caseType.IncrementalTotal CultureInfo.CurrentCulture.DateTimeFormat.GetMonthName(caseType.MonthNum))); } chartView.Series.Add(social); social.LegendTitle= Social ; social.Spline= true ; } elseif(iindex==3) { LineSeriescivil=newLineSeries(); FunctionsDALci=newFunctionsDAL(); foreach (varcaseTypeinci.ListCases(1dateFromdateTo)) { civil.DataPoints.Add(newCategoricalDataPoint(caseType.IncrementalTotal CultureInfo.CurrentCulture.DateTimeFormat.GetMonthName(caseType.MonthNum))); } chartView.Series.Add(civil); civil.LegendTitle= Civil ; civil.Spline= true ; } [...] }

Nitin Sontakke · Answer

Hello May be you should have also given the code for iindex == 2 so that we would know what is common (and hence repeated) and what is different and then give a solution.