Duplicate panels and controls created at runtime - Which button and textbox is it?

Question

My application creates panels and controls, ie. labels, textboxes, etc., based on user input. The controls on the panel are located in the same place each time.

I need your help to figure out how in the program to know which textbox named "txtHandi" goes with what panel.

My code falls apart here: void btnPlayerName_Click(object sender, EventArgs e)

It does not recognize the btnPlayerName I click on or the txtHandi. I am sure it is something I am overlooking!

1. Please help me understand how I can associate each of the "btnPlayerName" to the panel it shows up on.

2. and how I can associate each of the txtHandi on that same panel so the line of code "int playerHandicap = Convert.ToInt32(txtHandi.Text);"

in the void btnPlayerName_Click(object sender, EventArgs e) will work.

I suspect I will need help with:

int playerGross = Convert.ToInt32(myGross[i].Text);

int holeHandicap = (handicapofhole[i]);

in "void btnPlayerName_Click(object sender, EventArgs e)" also.

If you can jump start me with a few of these items I most likely will be able to connect the dots.

I am providing portions of code for your review.

Thanks in advance for your help.

Kevin Aung · Answer

Again I think the main challenge here is the group of objects not having an index of some sort to determine the grouping. This could easily be done by giving an index value to all objects in the same panel in the tag area (Ex: txtHandi.Tag = 1 btnPlayerName.Tag = 1). But if there's no index you could do the following. Since the player's objects are all contained in the panel you could search that specific panel to get the txtHandi value; void btnPlayerName_Click(object sender EventArgs e) { Panel curPanel; TextBox curHandi; Button curPlayerBtn; string HandiVal = ; curPlayerBtn = (Button)sender; curPanel = (Panel)curPlayerBtn.Parent; foreach (Control c in curPanel.Controls) { if (c is TextBox) { curHandi = (TextBox)c; HandiVal = curHandi.Text; } } } Secondly you should make a user control for these Player panels so that you won't have to use too much logic in the main game.

Tim Camper · Answer

I still don't see the code after trying to upload. Am I the only guy out there that is fooled by this interface. I do see some dithered out text that says  Select only zip and rar file. So do I just copy / paste from notepad right into the post? This is kind of embarrasing. using System; using System.Collections.Generic; using System.Collections; using System.ComponentModel; using System.Data; using System.Drawing; using System.Linq; using System.Text; using System.Windows.Forms; namespace WindowsFormsApplication1 { public partial class Form1 : Form { Player myPlayer; TextBox[] myGross = new TextBox[18]; Label[] myNet = new Label[18]; int[] handicapofhole = new int[] { 10 18 8 4 12 14 16 2 6 15 17 1 9 13 11 7 3 5 }; Label lblHandicap = new Label(); TextBox txtHandi = new TextBox(); Label lblGrossScores = new Label(); Label lblNet = new Label(); public List PlayerName = new List (); // use to decide who playing today public List PlayerPanels = new List (); // # of player panels = # of players public List PlayerButton = new List (); public List numButton = new List (); public Form1() { InitializeComponent(); } private void Form1_Load(object sender EventArgs e) { myPlayer = new Player(); txtHandi = new TextBox(); lots of other code here take out for purpose of this post } // This ends - private void Form1_Load(object sender EventArgs e) private void btnConfirmPlayers_Click(object sender EventArgs e) { //myGross = new TextBox[18]; //myNet = new Label[18]; foreach (string strItem in listBox1.Items) { PlayerName.Add(strItem); // adds player name to array list PlayerName } for (int i = 0; i { // instantiate new PlayerPanels // Initialize player panel control. // Begin Creating Player Panels Control Panel pnlPlayerPanel = new Panel(); pnlPlayerPanel.Location = new Point(10 200 + i * 126); pnlPlayerPanel.Size = new Size(900 116); pnlPlayerPanel.Name = pnl + PlayerName[i].ToString(); pnlPlayerPanel.BackColor = Color.BlanchedAlmond; pnlPlayerPanel.BorderStyle = System.Windows.Forms.BorderStyle.Fixed3D; //MessageBox.Show(PlayerName:  + PlayerName[i]); // yes it works // Initialize the Player Name Button that is on each panel one panel fore Button btnPlayerName = new Button(); btnPlayerName.Location = new Point(12 25); btnPlayerName.Size = new Size(146 57); btnPlayerName.Name = PlayerName[i].ToString(); btnPlayerName.Text = String.Format(Player {0} 
 {1} (i + 1) PlayerName[i]); btnPlayerName.BackColor = Color.Azure; btnPlayerName.TabStop = false; btnPlayerName.Enabled = true; numButton.Add(btnPlayerName); //MessageBox.Show(btnPlayerName:  + btnPlayerName.Name); // yes it works // To wire the event create a delegate instance and add it to the Click event. btnPlayerName.Click += new EventHandler(btnPlayerName_Click); // adding panel to PlayerPanels list PlayerPanels.Add(pnlPlayerPanel); Controls.Add(pnlPlayerPanel); // adding panel to form // adding button control to panel pnlPlayerPanel.Controls.Add(btnPlayerName); // Initialize the lblHandicap for the Panel control. Label lblHandicap = new Label(); lblHandicap.Location = new Point(140 5); lblHandicap.Text = Handicap; lblHandicap.Size = new Size(55 16); lblHandicap.TextAlign = ContentAlignment.MiddleLeft; pnlPlayerPanel.Controls.Add(lblHandicap); // Initialize the textHandi for the Panel control. TextBox txtHandi = new TextBox(); txtHandi.Location = new Point(172 25); txtHandi.Size = new Size(22 22); //txtHandi.Name = txtHandi_ + PlayerName[i].ToString(); txtHandi.Name = txtHandi; txtHandi.TabIndex = 0; txtHandi.TabStop = true; //txtHandi.Cursor txtHandi.BorderStyle = BorderStyle.Fixed3D; txtHandi.TextAlign = HorizontalAlignment.Center; txtHandi.MaxLength = 2; //txtHandi.Visible = true; txtHandi.Enabled = true; //MessageBox.Show(The name of handicap textbox is:  + txtHandi.Name); // yes it works pnlPlayerPanel.Controls.Add(txtHandi); //MessageBox.Show(The name of handicap textbox after control added to panel is:  + txtHandi.Name); // yes it works // Initialize label to indicate row of net scores. Label lblNet = new Label(); lblNet.Location = new Point(172 50); lblNet.Size = new Size(24 22); lblNet.Text = Net; lblNet.TextAlign = ContentAlignment.MiddleCenter; lblNet.BackColor = Color.Salmon; pnlPlayerPanel.Controls.Add(lblNet); // To wire the event create a delegate instance and add it to the Click event. lblNet.Click += new EventHandler(lblNet_Click); // not really using this... // creates textbox for gross scores and labels to show net scores after handicap myGross = new TextBox[18]; myNet = new Label[18]; for (int j = 0; j { if (j == 0 || j { myGross[j] = new TextBox(); myGross[j].Location = new Point(200 + j * 30 25); myGross[j].Name = myGross + j.ToString(); myGross[j].Size = new Size(22 22); myGross[j].Visible = true; myGross[j].TextAlign = HorizontalAlignment.Center; myGross[j].MaxLength = 1; //myGross[i].SelectAll(); how get to work see lesson 3 intermediate class myNet[j] = new Label(); myNet[j].Location = new Point(200 + j * 30 50); myNet[j].Name = myNet + j.ToString(); myNet[j].Size = new Size(22 22); myNet[j].Visible = true; myNet[j].BorderStyle = BorderStyle.Fixed3D; myNet[j].TextAlign = ContentAlignment.MiddleCenter; myNet[j].BackColor = Color.White; } else { myGross[j] = new TextBox(); myGross[j].Location = new Point(255 + j * 30 25); myGross[j].Name = myGross + j.ToString(); myGross[j].Size = new Size(22 22); myGross[j].Visible = true; myGross[j].TextAlign = HorizontalAlignment.Center; myGross[j].MaxLength = 1; myNet[j] = new Label(); myNet[j].Location = new Point(255 + j * 30 50); myNet[j].Name = myNet + j.ToString(); myNet[j].Size = new Size(22 22); myNet[j].Visible = true; myNet[j].BorderStyle = BorderStyle.Fixed3D; myNet[j].TextAlign = ContentAlignment.MiddleCenter; myNet[j].BackColor = Color.White; } } // Add control to the form. for (int j = 0; j { pnlPlayerPanel.Controls.Add(myGross[j]); pnlPlayerPanel.Controls.Add(myNet[j]); } // Initialize txtGrossOut control on panel2. TextBox txtGrossOut = new TextBox(); txtGrossOut.Location = new Point(470 25); txtGrossOut.Size = new Size(36 22); txtGrossOut.TabStop = false; //txtGrossOut.Name = txtGrossOut + (i + 1).ToString(); txtGrossOut.Text = ; // want to use array to sum this up instead of hard codeing. //txtGrossOut.Text = Convert.ToInt16(this.ParForEachHole[i].ToString()); txtGrossOut.TextAlign = HorizontalAlignment.Center; pnlPlayerPanel.Controls.Add(txtGrossOut); // Initialize lblNetOut control on panel2. // need to change to label Label lblNetOut = new Label(); lblNetOut.Location = new Point(470 50); //lblNetOut.Location = new Point(470 57); lblNetOut.Size = new Size(36 22); lblNetOut.TabStop = false; //lblNetOut.Name = lblNetOut + (i + 1).ToString(); ; lblNetOut.Text = ; //lblNetOut.Text = Convert.ToInt16(this.ParForEachHole[i].ToString()); lblNetOut.BorderStyle = BorderStyle.Fixed3D; lblNetOut.TextAlign = ContentAlignment.MiddleCenter; lblNetOut.BackColor = Color.White; pnlPlayerPanel.Controls.Add(lblNetOut); // Initialize txtGrossIn control on panel2. TextBox txtGrossIn = new TextBox(); txtGrossIn.Location = new Point(795 25); txtGrossIn.Size = new Size(36 22); txtGrossIn.TabStop = false; //txtGrossIn.Name = txtGrossIn + (i + 1).ToString(); ; txtGrossIn.Text = ; // want to use array to sum this up instead of hard codeing. //txtGrossIn.Text = Convert.ToInt16(this.ParForEachHole[i].ToString()); txtGrossIn.TextAlign = HorizontalAlignment.Center; pnlPlayerPanel.Controls.Add(txtGrossIn); // Initialize lblNetIn control on panel2. // need to change to label Label lblNetIn = new Label(); lblNetIn.Location = new Point(795 50); lblNetIn.Size = new Size(36 22); lblNetIn.TabStop = false; //lblNetIn.Name = lblNetIn + (i + 1).ToString(); ; lblNetIn.Text = ; //lblNetIn.Text = Convert.ToInt16(this.ParForEachHole[i].ToString()); lblNetIn.BorderStyle = BorderStyle.Fixed3D; lblNetIn.TextAlign = ContentAlignment.MiddleCenter; lblNetIn.BackColor = Color.White; pnlPlayerPanel.Controls.Add(lblNetIn); // Initialize txtGrossTotal control on panel2. TextBox txtGrossTotal = new TextBox(); txtGrossTotal.Location = new Point(850 25); txtGrossTotal.Size = new Size(36 22); txtGrossTotal.TabStop = false; //txtGrossTotal.Name = txtGrossTotal + (i + 1).ToString(); ; txtGrossTotal.Text = ; // want to use array to sum this up instead of hard codeing. //txtGrossTotal.Text = Convert.ToInt16(this.ParForEachHole[i].ToString()); txtGrossTotal.TextAlign = HorizontalAlignment.Center; pnlPlayerPanel.Controls.Add(txtGrossTotal); // Initialize lblNetTotal control on panel2. // need to change to label Label lblNetTotal = new Label(); lblNetTotal.Location = new Point(850 50); lblNetTotal.Size = new Size(36 22); lblNetTotal.TabStop = false; //lblNetTotal.Name = lblNetTotal + (i + 1).ToString(); ; lblNetTotal.Text = ; lblNetTotal.BorderStyle = BorderStyle.Fixed3D; lblNetTotal.TextAlign = ContentAlignment.MiddleCenter; lblNetTotal.BackColor = Color.White; pnlPlayerPanel.Controls.Add(lblNetTotal); } } void lblNet_Click(object sender EventArgs e) // not using this... { throw new NotImplementedException(); } void btnPlayerName_Click(object sender EventArgs e) // would like to click on button of player on panel to do following... { // how should I code so this event knows what button it is? //throw new NotImplementedException(); // 01/01/11 doesn't know who txtHandi is MessageBox.Show(The name of handicap textbox after btnPlayerName_Click is:  + txtHandi.Name); //int playerHandicap = Convert.ToInt32(this.txtHandi.Text); int playerHandicap = Convert.ToInt32(txtHandi.Text); // How should I code so code knows which txtHandi got created with its player button. for (int i = 0; i { int playerGross = Convert.ToInt32(myGross[i].Text); int holeHandicap = (handicapofhole[i]); // . (variable(s) passed to PrepareNet method in Player class. myPlayer.PrepareNet(playerGross playerHandicap holeHandicap); myNet[i].Text = Convert.ToString(myPlayer.GetNet()); // GetNet method figures actual net for each hole. } } private void checkedListBox1_ItemCheck(object sender ItemCheckEventArgs e) { if (e.NewValue == CheckState.Checked) { this.listBox1.Items.Add(this.checkedListBox1.SelectedItem.ToString()); btnConfirmPlayers.Enabled = true; //PlayerName.Clear(); } else { this.listBox1.Items.Remove(this.checkedListBox1.SelectedItem.ToString()); //btnConfirmedPlayersToday.Enabled = false; // 1/22/10 needs fixed. //PlayerName.Clear(); } } private void btnClearPlayerPanels_Click(object sender EventArgs e) { // clear the listBox1 & uncheck all checked boxes in checkedListBox1 listBox1.Items.Clear(); numButton.Clear(); //PlayerName.Clear(); IEnumerator myEnumerator; myEnumerator = checkedListBox1.CheckedIndices.GetEnumerator(); int y; while (myEnumerator.MoveNext() != false) { y = (int)myEnumerator.Current; checkedListBox1.SetItemChecked(y false); } // remove panels will get added again in the player confirmed region for (int i = PlayerName.Count - 1; i >= 0; i--) { this.Controls.Remove(PlayerPanels[i]); PlayerPanels[i].Dispose(); } PlayerName.Clear(); PlayerPanels.Clear(); //txtAddGuest.Clear(); // 13/30/10 } } } // Here is the Player class it works fine in prototype. using System; using System.Collections.Generic; using System.Linq; using System.Text; namespace WindowsFormsApplication1 { class Player { private int gross; private int handicap; private int holehandicap; private int nett; // playerGross playerHandicap holeHandicap public void PrepareNet(int _gross int _handicap int _holehdcp) { gross = _gross; holehandicap = _holehdcp; handicap = _handicap; } public int GetNet() { if (holehandicap > handicap) { nett = gross; return nett; } else { nett = gross - 1; return nett; } } } }

Tim Camper · Answer

Something tells me I did not get the sample code in the original post. I will try to include at the end of this reply. Kevin ask: So when do the textbox and panel get created dynamically? Answer: When the user clicks on btnConfirmPlayers. The quotes here indicate the name of the button. btnConfirmPlayers is already on the form and does not get created at runtime. Go to the block of code where TextBox txtHandi = new TextBox(); is dynamcially generated. This is where I get stuck. What programming techniques do I use so when I click on the button btnPlayerName the code knows what txtHandi textbox is associated with that run of the for loop? The same applies to myGross[j] and so on. Just imagine a form with a panel of controls. The number of panels is dependent on the number of players. So that varies based on user input. The key here is you may have 10 panels and controls that look exactly alike with the exception of the btnPlayerName which knows who the player is. So when I click on btnPlayerName (for a specific player) I want to enter an integer number that is the player handicap. Following that I want to enter the players gross scores in their respective textboxes. Then send to method in the Player class to figure the net scores and return in the respective net score textboxt. Another post suggest I should be making one component then make however many instances of that component. Again thanks in advance for your input! Tim

Kevin Aung · Answer

So when do the textbox and panel get created dynamically? When the user clicks on btnPlayerName? Or does that button get created dynamically as well? What I would do is create the objects and give them some sort of an index either in their Name or Tag. Create objects: private void CreateObjects() { int index; TextBox curTextBox = new TextBox(); curTextBox.Name = txtSomeTextBox + index.ToString(); // or // curTextBox.Tag = index.ToString(); Panel curPanel= new Panel(); curPanel.Name = panelSomePanel + index.ToString(); // or // curPanel.Tag = index.ToString(); curPanel.Controls.Add(curTextBox); this.Controls.Add(curPanel); } Same for buttons and what not. This way you have that index to check to see how the objects need to group or where it belongs to. Keep in mind if you create a button dynamically and point to the same event handler (ex: btnPlayerName_Click) they're all gonna do the same thing unless you determine in your code where the button came from and what it needs to do.

Gomathi Palaniswamy · Answer

Hi friend  get like for (i = 0; i { if (sourcefrm.Controls[i] is Panel) { Panel rg = (Panel)sourcefrm.Controls[i]; foreach (Control c in rg.Controls) { if (c is TextBox) { c.Enabled = true; } if (c is ComboBox) { c.Enabled = true; } } } }