Finalize part

Question

Vulpes I have been looking over the game lol so many bugs . But the main few are like Start the game click Start chose 5-100 Range and then you are able to bet all your money even if its over 100. But then when you click deal button it will display windows saying Bet must be between 5 and 100. How would I not allow the user to bet over the limit? Even though I tried to implement my limits  they don't work... Also my when you placed your bet(anteLabel) and decide to Raise it will copy from anteLabel to raiseLabel and if you click again it will copy the money to raise2Label. The problem is it should subtract money from the players money and if its not enough then Raise button shouldn't be available and the only choice is to continue( because if you have 200$ and bet 100 first time and then click Raise you will bet your last 100 and 0 remain which means you cant raise again). I hope its not too much to ask lol.... Thank you!

Vulpes · Answer

Good :) In the meantime I've been working on the first problem. I've concluded that it's just too complicated to disable the chip buttons to prevent the user from making an illegal bet. It's better to just disallow it and pop up a messagebox so the user has some feedback. I hadn't realized before that the user could press several chip amounts before pressing the Deal button so I agree that having the $1 chip isn't a problem. Anyway I've fixed it now so that the total bet can't exceed the maximum. If the user attempts to do so a messagebox pops up to tell him or her. There's nothing that can be done to make sure the bet is greater than or equal to the minimum until the Deal button is pressed so I haven't changed that code at all. Anyway these are the changes. I'd just comment out existing code until you're sure this is working OK with the other changes you've made as I haven't looked at them yet: // in LetEmRide class public void DisplayPlayerMoney(int dollars) { playerMoneyLabel.Text =  + dollars; /* Comment this lot out //=======1========== if (dollars { chipBet1Button.Enabled = false; } if (dollars > 1) { chipBet1Button.Enabled = true; } //=======5========== if (dollars { chipBet5Button.Enabled = false; } if (dollars > 5) { chipBet5Button.Enabled = true; } //=======25========== if (dollars { chipBet25Button.Enabled = false; } if (dollars > 25) { chipBet25Button.Enabled = true; } //======100========= if (dollars { chipBet100Button.Enabled = false; } if (dollars > 100) { chipBet100Button.Enabled = true; } //=====500========== if (dollars { chipBet500Button.Enabled = false; } if (dollars > 500) { chipBet500Button.Enabled = true; } */ } // these handlers have all been changed private void chipBet1Button_Click(object sender EventArgs e) { if (playerbet + 1 { if (game.Bet(1)) { playerbet += 1; anteLabel.Text = Convert.ToString(playerbet); } } else { MessageBox.Show(Sorry you can't bet more than  + maxBet.ToString(C0)); } } private void chipBet5Button_Click(object sender EventArgs e) { if (playerbet + 5 { if (game.Bet(5)) { playerbet += 5; anteLabel.Text = Convert.ToString(playerbet); } } else { MessageBox.Show(Sorry you can't bet more than  + maxBet.ToString(C0)); } } private void chipBet25Button_Click(object sender EventArgs e) { if (playerbet + 25 { if (game.Bet(25)) { playerbet += 25; anteLabel.Text = Convert.ToString(playerbet); } } else { MessageBox.Show(Sorry you can't bet more than  + maxBet.ToString(C0)); } } private void chipBet100Button_Click(object sender EventArgs e) { if (playerbet + 100 { if (game.Bet(100)) { playerbet += 100; anteLabel.Text = Convert.ToString(playerbet); } } else { MessageBox.Show(Sorry you can't bet more than  + maxBet.ToString(C0)); } } private void chipBet500Button_Click(object sender EventArgs e) { if (playerbet + 500 { if (game.Bet(500)) { playerbet += 500; anteLabel.Text = Convert.ToString(playerbet); } } else { MessageBox.Show(Sorry you can't bet more than  + maxBet.ToString(C0)); } } // in Game class public bool Bet(int amount) // now returns a bool { if (player.SetBetAmount(amount)) { gui.DisplayPlayerMoney(player.Money); return true; } return false; } // in Player class public bool SetBetAmount(int bet) // now returns a bool { if (money { MessageBox.Show(Sorry you don't have sufficient money to make this bet); return false; } money -= bet; this.bet += bet; return true; } /* Comment out this method as I don't think we'll need it now public void RaiseBetAmount(int bet) { if (money money -= bet; this.bet += bet; } */

Prime b · Answer

Works perfectly and it didnt affect my code at all!

Prime b · Answer

Vulpes I believe I fixed the problem with labels displaying the same amount of money without subtracting it from the player's money first I updated the form http://www.4shared.com/rar/Di4P8pGT/LetItRide.html

Prime b · Answer

Oh and I guess you didn't read my reply in last thread about the bet range . I need those since they are the teachers requirements. And dont I need 1 dollar chip? what if the person wants to bet 101? User Story: The user will start the game. Upon game start the user will be given a random amount of money. This amount will be between $100-1000. The user will then choose from three different betting limits (minimum bet – maximum bet) $5-100 $25-500 and $50-1000. The user will then begin the game loop you can read the requirements here http://www.4shared.com/file/6H4yor8c/c_charp_project_2_requirements.html?refurl=d1url

Prime b · Answer

Well see this is my code to force the range right but you can trick it if you click 5-100 range and then you can bet all your money but then when you click deal then the message will pop up saying range error same thing with 25-500 range button. Its weird private void dealButton_Click(object sender EventArgs e) { if (playerbet == 0) { MessageBox.Show(You have to place bet first Bet required); } else { if (playerbet maxBet) { MessageBox.Show(Bet must be between  + minBet +  and  + maxBet Bet range error); } else { game.Deal(); int betAmount = Convert.ToInt32(anteLabel.Text); ActionButtons(true); EnableRangeBet(false); EnableChips(false); dealButton.Enabled = false; } } } I am assuming you talking about the limit of player's money. Well then no you cannot go in to the negative if you have 200 dollars  and you bet 100 you can raise only 1 time and all you have left is Continue and since you have 0 money and you cant raise again. I am not sure if this answers your question. If you play game online and click 500 chip and click dealassuming you lost first your deal you will have 500 left now bet 300 now you got 200 left and you cant raise because raise has to be the same amount of money as first bet. In my case its all messed up if you bet 125 for example and click raise it will just copy whatever is in the first label and not going to subtract from players money...

Vulpes · Answer

If you're stuck with the 5 to 100 range then I'd get rid of the $1 chip altogether. The best way to stop people betting is to disable the chip buttons after the initial bet has been made and then re-enable them on the next deal. In fact I see you're doing something like this already since when you click the 5 to 100 range the $500 chip becomes invisible. One thing I wasn't clear about is whether when the player raises that should count against the limit or not? I'm too tired now to think about the second bug but I'll have a look at it tomorrow.