Get No Of Days

I'm wondering , how this method leads to performance impact? If I'm not wrong, you will not be populating 1000 of records into grid or whatever tabular controls you are going to choose. 

if you are replacing with any other control, you can still go ahead and use the same method from code behind. However, if there is a valid reason(for an instance: business requirement), certainly it would be a change. 

My personal opinion, should not add any logic in presentation logic. 

However, its all depends on how your architecture decision. 

The code assumes that the control is the appropriate choice for displaying the number of days. However, this may limit the flexibility to change the presentation in the future. If there's a need to change the display format or use a different control, it would require modifications in multiple places.

The code mixes business logic with presentation logic by including the GetNumberOfDays method directly in the code-behind file. This can make the code less maintainable, especially as the application grows and more functionality is added. 
 

The code calls the GetNumberOfDays method for each item bound to the control. Depending on the size of the data source and the frequency of updates, this could result in a performance impact.

To achieve the desired behavior, you can use an inline code block within the Text attribute of the control. Here's an updated version of the code:

In the code-behind file (e.g., .aspx.cs or .aspx.vb), define a method called GetNumberOfDays that calculates the number of days if the conditions are met:

protected string GetNumberOfDays(object nextActionDate)
{
    if (nextActionDate != null && nextActionDate != DBNull.Value && !string.IsNullOrEmpty(nextActionDate.ToString()))
    {
        DateTime nextAction = Convert.ToDateTime(nextActionDate);

        if (nextAction <= DateTime.Now)
        {
            TimeSpan duration = DateTime.Now - nextAction;
            return duration.Days.ToString();
        }
    }

    return string.Empty; // Return empty string if conditions are not met
}

In this code, the GetNumberOfDays method checks if the nextActionDate is not null, not DBNull.Value, and not an empty string. If these conditions are met and the NextActionDate is less than or equal to the current date (DateTime.Now), it calculates the difference in days using a TimeSpan object and returns the number of days as a string. Otherwise, it returns an empty string.

Note that the Eval method is used to evaluate the value of the NextActionDate from the data source binding context. Make sure that the data source is properly configured to provide the correct value for NextActionDate.

Hi Ramco kindly check the upddated code below.

In this code, we added a condition using the ternary operator (? :) to check if the NextActionDate is not null, not empty, and if it is less than or equal to the current date. If the condition is true, it calculates the number of days between NextActionDate and the current date using (DateTime.Now - Convert.ToDateTime(Eval("NextActionDate"))).Duration().Days and converts it to a string. Otherwise, it assigns an empty string.

Make sure to replace the Eval("NextActionDate") with the appropriate data binding expression based on your actual implementation.