How do I add exception handling in my code?

Question

I need help with this code. I need to do the following:

Create an exception handling to throw an error if:

1) The number of integer in each row are not equal to each other for example: Matrix = [ 3 4; 9 8 1]should be: matrix = [ 3 4 2; 9 8 1]

2) the semicolon ";" that I use as a separator is replace by an invalid character such as: matrix = [ 3 4 2 # 9 8 1]

3) The starting character for the matrix is not '[' or the ending character of the matrix is not ']'. For example, matrix = ] 1 2 3[ should be matrix = [1 2 3]

This is my code:

This is from my main in which I create the string and call the class method.

string text = "A = [8 5 5 4; 2 6 5 3; 8 5 2 6]";

this is my class:

public string[,] Matrix(string text)

{

try

{

try

{
char[] splitOne = { '[', ']' };
char[] splitTwo = { ';' };
char[] splitThree = { ' ' };
words = text.Split(splitOne)[1]
.Split(splitTwo, StringSplitOptions.RemoveEmptyEntries)
.Select(x => x.Split(splitThree, StringSplitOptions.RemoveEmptyEntries))
.ToArray();
}

if (!text.Contains(";")) { throw new Exception("Malformed separator'"); }

if (text.Split(';')[0].Replace(" ", "").Length != text.Split(';')[1].Replace(" ", "").Length)

{ throw new Exception("unbalanced matrix"); }

}
catch (Exception a)
{
Console.WriteLine(a.Message);
}
}

catch (Exception b)
{

Console.WriteLine(b.Message);

}

string[,] matrix = new string[words.Length, words[0].Length];
for (int i = 0; i < words.Length; ++i)
{
            for (int j = 0; j < words[i].Length; ++j)
               {
                           matrix[i, j] = words[i][j];
               }
}
                  for (int i = 0; i < matrix.GetLength(0); i++)
                     {
                        for (int j = 0; j < matrix.GetLength(1); j++)
                        {
                              Console.Write("{0} ", matrix[i, j]);
                        }
                              Console.WriteLine();
                        }
return matrix;

}

I got the separator part to work, But I need help on number 1. I don't know if that code is correct.

carmelo anthony · Answer

I will email you my whole code. You will see that if you take a number out of the matrix or leave it in it will still throw the message.

Nishant Mittal · Answer

That means that your index is reffring @ wrong place..There is no value at particular index. Mail me you solution @nishant.mittal19@gmail.com

carmelo anthony · Answer

yes

Nishant Mittal · Answer

What is the exception ? Is it index out of bound?

carmelo anthony · Answer

It is throwing the exception message if (text.Split(';')[0].Replace(  ).Length != text.Split(';')[1].Replace(  ).Length) { throw new Exception (unbalanced matrix ); } But I don't know if this code is correct. The nested try-catch is working. I tried it on simple things and it seemed to work fine.

Nishant Mittal · Answer

It is throwing exception?Or seems issue in your logic.

carmelo anthony · Answer

ohh okay. so I will make a different try catch for each case instead of nesting it? But how about my code for this part: The number of integer in each row are not equal to each other for example: Matrix = [ 3 4; 9 8 1] should be : matrix = [ 3 4 2; 9 8 1] Even when the matrix is balanced and have the right number of columns it still displays the message from my exception.

Nishant Mittal · Answer

Hi Seems you need to segregate your code based on exception you want. Let Say for point 1 The number of integer in each row are not equal to each other for example: Matrix = [ 3 4; 9 8 1] should be : matrix = [ 3 4 2; 9 8 1] one try catch same will follow other 2 points as well. Generally we use to through generic exception from any function as you have different scanario you have to handle the same in logic with different try catch block.