Ideal way to retrive dataset.

Question

This is DataSet retriving code from IBUYSPY Events Module. public DataSet GetEvents(int moduleId) { // Create Instance of Connection and Command Object SqlConnection myConnection = new SqlConnection(ConfigurationSettings.AppSettings[connectionString]); SqlDataAdapter myCommand = new SqlDataAdapter(GetEvents myConnection); // Mark the Command as a SPROC myCommand.SelectCommand.CommandType = CommandType.StoredProcedure; // Add Parameters to SPROC SqlParameter parameterModuleId = new SqlParameter(@ModuleId SqlDbType.Int 4); parameterModuleId.Value = moduleId; myCommand.SelectCommand.Parameters.Add(parameterModuleId); // Create and Fill the DataSet DataSet myDataSet = new DataSet(); myCommand.Fill(myDataSet); // Return the DataSet return myDataSet; } My Question is 1) Is this ideal way to retrive data? 2) Will it return connection back to pool?

Giovanni Bejarasco · Answer

I'm also aware of this jigar and this is what so great about ADO.NET. It really caters for disconnected data. The habit may be traced to my ADO experiences. Closing a closed connection won't generate exception don't worry. :)

Jigar Desai · Answer

Thanks bunny SqlDataAdapter.Fill(); Under covers does following 1)Opens connection 2)Fills dataset and 3)Closes connection. Then why we need to close connection again?

Giovanni Bejarasco · Answer

The words ideal best ultimate and other superlative adjectives are very vague in the world of programming. You have to ask questions about your application. What are the onstraints? (time budget manpower etc). Honestly I don't have any problem with your code. If it does retrieve the dataset with the right info then your on the go! About the second question YES but I suggest closing the connection. :) I'm new to this site but I know this has many articles about retrieving data.