Logic behind the game

Question

Ok I honestly don't know how this works. How would I evaluate hands Vulpes? When I click deal and cards displayed then if anything above pair 10's would give player money otherwise it goes back to house / w.e you call him. As you can see in my Game class I got PayOutMoney method that contains all the hands and such but now how would I connect that methods with the cards that will be displayed? The rules are here http://www.coolcat-casino.com/table-games/let-em-ride.php Don't click on PlayNow link because it will open an .exe file. This link http://www.freepoker.com/free-let-em-ride-poker is if you want to see where I am copying my game from. You can also play it there

Vulpes · Answer

OK I've changed the Player class so it's more in line with what I think you need: class Player { private Hand fiveCards; private int money; private int bet = 0; public int Money { get { return money; } set { money = value; } } public Hand Hand { get { return fiveCards; } set { fiveCards = value; } } public Player(int startingAmount) { fiveCards = new Hand(); money = startingAmount; } public int GetBetAmount() { return bet; } public void SetBetAmount(int bet) { if (money money -= bet; this.bet = bet; } public void RaiseBetAmount(int bet) { if (money money -= bet; this.bet += bet; } } I've also made some changes to the Games class so that the money should now reflect the result of the deal : class Game { private LetEmRide gui; private GraphicalDeck deck; //private Hand playerHand; // not needed private Player player; //private int betAmount; // not needed Random gen = new Random(); public Game(LetEmRide gui) { this.gui = gui; } public void StartGame() { deck = new GraphicalDeck(); int money = gen.Next(100 1001); player = new Player(money); player.Hand = new Hand(); gui.DisplayPlayerMoney(player.Money); gui.ShowBetAmount(player.Money); gui.EnableChips(false); } public void Bet(int amount) { player.SetBetAmount(amount); // changed here gui.DisplayPlayerMoney(player.Money); } public void ShowMyHand() { gui.ShowHand(player.Hand); } public void Deal() { deck.Shuffle(); deck.SwitchDeckColor(); for (int count = 0; count { player.Hand.AddCard(deck.RemoveTopCard()); } gui.ShowHand(player.Hand); } public void PayOutMoney() { int payOut = 0; // changed from 1 int betAmount = player.GetBetAmount(); // added this line switch (player.Hand.DetermineHandByType()) { case HandType.NOTHING: // bet aready deducted from money leave payOut as 0 //pay the dealer break; case HandType.TENS_OR_BETTER: payOut = betAmount * 1; break; case HandType.TWO_PAIRS: payOut = betAmount * 2; break; case HandType.THREE_OF_A_KIND: payOut = betAmount * 3; break; case HandType.STRAIGHT: payOut = betAmount * 5; break; case HandType.FLUSH: payOut = betAmount * 8; break; case HandType.FULL_HOUSE: payOut = betAmount * 11; break; case HandType.FOUR_OF_A_KIND: payOut = betAmount * 50; break; case HandType.STRAIGHT_FLUSH: payOut = betAmount * 200; break; case HandType.ROYAL_FLUSH: payOut = betAmount * 1000; break; } //Add (or subtract) the bet amount from the players cash. player.Money += payOut; gui.DisplayPlayerMoney(player.Money); //or... // int payout = player.DetermineHand(); //betAmount * payout : is what the player gets... } public void FlipLeft() { //both cartds flipped you need to go figure out if this was a winner or not. //diplsay the results... //Tell the gui to clear itself and get ready for a new hand //things like enable the betting buttons again. PayOutMoney(); // added this line gui.EnableChips(true); } }

Prime b · Answer

it worked! Thank you vulpes!

Prime b · Answer

Also if you look at my Player class I do have method called GetBetAmount(int bet) method the problem is I don't know how to connect that method to gui class.... I did fix the double bet issue I had a method in Deal button that would deal bet again.

Prime b · Answer

Vulpes I deleted old version and forgot to update it I fixed few more bugs and mistakes so here's the latest version http://www.4shared.com/rar/kh6OXWk7/LetItRide.html

Vulpes · Answer

4shared.com is telling me that the file is deleted so I'm using the last version I have. However you have a number of problems here. 1. The Game.FlipLeft method which is called when the Continue button is pressed and both cards are displayed needs to call the Game.PayOutMoney method. 2. The PayOutMoney method is not having any effect on the player's money because: (a) the betAmount field has not been set and so still has its default value of 0. (b) it needs to call: gui.DisplayPlayerMoney(player.Money); to display the new amount. 3. The playerMoneyLabel is getting debited again when the Deal button is pressed even though it was already debited when the bet was made. This is because the Game.Bet is being called on both occasions and this in turn calls the Player.GetBetAmount method. I think you really have a design flaw here - the Player class should store the amount of the bet not the Game class and needs both Get and Set methods.

Prime b · Answer

I changed it but still even now when i click continue button  it just reveals the rest two cards and that's it it doesn't subtract the bet amount nor adds up. I added new stuff  http://www.4shared.com/rar/C1PvgcBq/LetItRide.html

Vulpes · Answer

I don't think you need to do anything in the Deal method itself. You only need to know what the handtype is when you call the PayOutMoney method and if you change the start of the switch statement in that method to: switch ( player.Hand .DetermineHandByType()) then that should cope with that. If your other questions are to do with hand analysis then I'd continue asking them on this thread but if it's a new topic then I'd start a new one.

Prime b · Answer

I updated the form http://www.4shared.com/rar/6GV8MlvO/LetItRide.html But you probably have the same thing as me. So this is hand evaluator. I have a lot more questions would you like me to open new thread? And now do I put all these methods to Deal button or?

Vulpes · Answer

Good that makes life a lot easier :) Here's what I think you need for the last three methods. When checking whether a hand contains 3 of a kind then (bearing in mind it's sorted) the threesome could be cards 0 to 2 cards 1 to 3 or cards 2 to 4. Similar logic applies to the other 2 hand types: private bool IsThreeOfAkind() { return (hand[0].FaceValue == hand[2].FaceValue) || (hand[1].FaceValue == hand[3].FaceValue) || (hand[2].FaceValue == hand[4].FaceValue); } private bool IsTwoPairs() // changed name of this method { return ((hand[0].FaceValue == hand[1].FaceValue) && (hand[2].FaceValue == hand[3].FaceValue)) || ((hand[0].FaceValue == hand[1].FaceValue) && (hand[3].FaceValue == hand[4].FaceValue)) || ((hand[1].FaceValue == hand[2].FaceValue) && (hand[3].FaceValue == hand[4].FaceValue)); } private bool IsTensOrBetter() { return ((hand[0].FaceValue == hand[1].FaceValue) && hand[0].GetNumericValue() >= 10) || ((hand[1].FaceValue == hand[2].FaceValue) && hand[1].GetNumericValue() >= 10) || ((hand[2].FaceValue == hand[3].FaceValue) && hand[2].GetNumericValue() >= 10) || ((hand[3].FaceValue == hand[4].FaceValue) && hand[3].GetNumericValue() >= 10); }

Prime b · Answer

I am allowed to change anything and anyway I want it. So vulpes let's do what you think is the best! I updated the code http://www.4shared.com/rar/dUgGwgEu/LetItRide.html I also going to PM you the info to log in in 4shared just in case.

Vulpes · Answer

No it doesn't matter - I can wait 20 seconds ;) My head's a bit clearer than it was last night and I've noticed a few things I missed before. Firstly TWO_OF_A_KIND should be TWO_PAIRS i.e. 2 kings and 2 queens stuff like that. So the HandType enum needs altering. Secondly it would be better from both a coding and efficiency point of view if the method calls in the DetermineHandByType method were rearranged so that the best hands were checked first rather than the worst hands. When checking whether a hand contains say 3 of a kind we wouldn't then need to check first that it doesn't contain 4 of a kind and then have to perform the same calculation again when it comes to checking for 4 of a kind. In other words this is what I think we need: public HandType DetermineHandByType() { HandType result = HandType.NOTHING; if (!IsComplete()) return result; Sort(); if (IsRoyalFlush()) //royal flush i.e. best hand now first { result = HandType.ROYAL_FLUSH; } else if (IsStraightFlush()) // Straight Flush { result = HandType.STRAIGHT_FLUSH; } else if (IsFourOfKind()) //Four of a Kind { result = HandType.FOUR_OF_A_KIND; } else if (IsFullHouse()) // Full House { result = HandType.FULL_HOUSE; } else if (IsFlush()) // Flush { result = HandType.FLUSH; } else if (IsStraight()) // Straight { result = HandType.STRAIGHT; } else if (IsThreeOfAkind()) // Three of a Kind { result = HandType.THREE_OF_A_KIND; } else if (IsTwoOfAKind()) //two of a Kind { result = HandType.TWO_PAIRS; // changed here } else if (IsTensOrBetter()) //10s or better { result = HandType.TENS_OR_BETTER; } return result; } I don't know whether you're allowed to change this code but if you can then I think you should. Thirdly the code I did for the flush contains a superfluous line which should be deleted: private bool IsFlush() { //if(!IsComplete()) return false; // remove this line string suit = hand[0].Suit; for(int index = 1; index { if(hand[index].Suit != suit) return false; } return true; } Fourthly the code I did for the straight is wrong - I haven't checked that some of the cards might have the same face value. I'd use this instead: private bool IsStraight() { int prev = hand[0].GetNumericValue(); for(int index = 1; index { int next = hand[index].GetNumericValue(); if((next - prev) != 1) return false; prev = next; } return true; } Finally the code to do the remaining cases is more complicated than you think. I can correct it but need to know whether it's OK to rearrange the code in the DetermineHandByType method first.

Prime b · Answer

Vulpes ok I am going to try to upload the updated version to website and also to 4shared. I am not sure if its correct the way I finished it. Maybe you want me to give the info from the account so you can log in and just download it without waiting? If yes just tell me. http://www.4shared.com/rar/lc5i9glE/LetItRide.html

Prime b · Answer

ohh ok  i will do that and and will upload updated result I will use 4shared ok? Because i tried to re-upload the file to the website but it just wont stay.

Vulpes · Answer

Unfortunately the download isn't now working - though no matter I've used the previous version :) What you need to do now is to figure out the type of the hand using the methods in the Hand GraphicalCard and Card classes. It's easier if you sort the hands first which I'd do in the DetermineHandByType method. I've done the easier ones for you (a bit rushed so watch out for bugs!) but there's a still few more left for you to do: public HandType DetermineHandByType() { HandType result = HandType.NOTHING; if (!IsComplete()) return result; Sort(); if (IsTensOrBetter()) //10s or better { result = HandType.TENS_OR_BETTER; } else if (IsTwoOfAKind()) //two of a Kind { result = HandType.TWO_OF_A_KIND; } else if (IsThreeOfAkind()) // Three of a Kind { result = HandType.THREE_OF_A_KIND; } else if (IsStraight()) // Straight { result = HandType.STRAIGHT; } else if (IsFlush()) // Flush { result = HandType.FLUSH; } else if (IsFullHouse()) // Full House { result = HandType.FULL_HOUSE; } else if (IsFourOfKind()) //Four of a Kind { result = HandType.FOUR_OF_A_KIND; } else if (IsStraightFlush()) // Straight Flush { result = HandType.STRAIGHT_FLUSH; } else if (IsRoyalFlush()) //royal flush { result = HandType.ROYAL_FLUSH; } return result; } private bool IsRoyalFlush() { return IsStraightFlush() && hand[4].FaceValue == Ace; } private bool IsStraightFlush() { return IsStraight() && IsFlush(); } private bool IsFourOfKind() { return (hand[0].FaceValue == hand[3].FaceValue) || (hand[1].FaceValue == hand[4].FaceValue); } private bool IsFullHouse() { return ((hand[0].FaceValue == hand[1].FaceValue) && (hand[2].FaceValue == hand[4].FaceValue)) || ((hand[0].FaceValue == hand[2].FaceValue) && hand[3].FaceValue == hand[4].FaceValue)) } private bool IsFlush() { if (!IsComplete()) return false; string suit = hand[0].Suit; for (int i = 1; i { if (hand[i].Suit != suit) return false; } return true; } private bool IsStraight() { int first = hand[0].GetNumericValue(); int last = hand[4].GetNumericValue(); return (last - first) == 4; } private bool IsThreeOfAkind() { return true; // not yet done } private bool IsTwoOfAKind() { return true; // not yet done } private bool IsTensOrBetter() { return true; // not yet done }