Need help in update query

Question

Hi This update query is not working. Can anyone help me with this one. command.CommandText = UPDATE [Root_Cause_App_Rsn_Lookup] SET [Root_Cause_Grp_Cd]=' + RootCauseGroup + ' [Root_Cause_App_Rsn_Cd]=' + RootCauseAppReason + ' [Root_Cause_App_Rsn_Desc]=' + RootCauseAppReasonDescription + ' WHERE ([Root_Cause_Grp_Cd)= ' + RootCauseGroup + ') ;

Joxin Stanly · Answer

based on your table structure i recommend using -: UPDATE [Root_Cause_App_Rsn_Lookup] SET [Root_Cause_App_Rsn_Desc]=' + RootCauseAppReasonDescription + ' WHERE ([Root_Cause_Grp_Cd]= ' + RootCauseGroup +' and [Root_Cause_App_Rsn_Cd]= ' + RootCauseAppReason +');

Vignesh Kumar · Answer

I tried it and they are getting inserted in sql server.

Vignesh Kumar · Answer

Yeah will try that. Thanks a lot Joxin for your timely help.

Joxin Stanly · Answer

I coudn't find anything wrong in your code. Please try running the Insert query (modify query with vales accordingly ) directly in sql server and see if it gets inserted ...

Vignesh Kumar · Answer

No error is generating. I don't see the data getting inserted into the grid. Pls look into the code I am using. protected void ResultGridView_RowCommand(object sender GridViewCommandEventArgs e) { try { if (e.CommandName.Equals(AddNew)) { TextBox RootCauseGroup = (TextBox)GridView1.FooterRow.FindControl(txtRootCauseGroup); TextBox RootCauseAppReason = (TextBox)GridView1.FooterRow.FindControl(txtRootCauseAppReason); TextBox RootCauseAppReasonDescription = (TextBox)GridView1.FooterRow.FindControl(txtRootCauseAppReasonDescription); RootCauseAppReasonDataBO.InsertRootCauseAppReasonValues(RootCauseGroup.Text RootCauseAppReason.Text RootCauseAppReasonDescription.Text); FillVendorGrid(); } } catch (Exception exc) { Logger.LogError(exc MethodBase.GetCurrentMethod().ToString()); UtilityMethods.RedirectToErrorPage(Constants.Message_ErrorProcessingRequest); } } public static bool InsertRootCauseAppReasonValues(string RootCauseGroup string RootCauseAppReason string RootCauseAppReasonDescription) { string CS = ConfigurationManager.ConnectionStrings[Constants.EARSdConnectionString].ConnectionString; using (SqlConnection connection = new SqlConnection(CS)) { SqlCommand command = new SqlCommand(); command.Connection = connection; command.CommandText = INSERT INTO [Root_Cause_App_Rsn_Lookup]([Root_Cause_Grp_Cd][Root_Cause_App_Rsn_Cd][Root_Cause_App_Rsn_Desc]) Values(' + RootCauseGroup + '' + RootCauseAppReason + ' ' + RootCauseAppReasonDescription + '); connection.Open(); command.ExecuteNonQuery(); } return true; }

Joxin Stanly · Answer

for me the query looks ok any error it is generating...

Vignesh Kumar · Answer

Hi Joxin All fine now. Finally this insert query is not working. command.CommandText = INSERT INTO [Root_Cause_App_Rsn_Lookup]([Root_Cause_Grp_Cd][Root_Cause_App_Rsn_Cd][Root_Cause_App_Rsn_Desc]) Values(' + RootCauseGroup + '' + RootCauseAppReason + ' ' + RootCauseAppReasonDescription + ') ;

Joxin Stanly · Answer

try below -: UPDATE [Root_Cause_Grp_Cd_Lookup] SET [Root_Cause_Grp_Cd_Desc]=' + RootCauseGroupDescription + ' WHERE ([Root_Cause_Grp_Cd]=' + RootCauseGroup +');

Vignesh Kumar · Answer

Hi Joxin That was fine. I AM STUCK WITH MY UPDATE QUERY NOW. I was able to add successfully but couldn't update. Can you pl shelp command.CommandText = UPDATE [Root_Cause_Grp_Cd_Lookup] SET [Root_Cause_Grp_Cd] =' + RootCauseGroup + ' [Root_Cause_Grp_Cd_Desc]=' + RootCauseGroupDescription + ' WHERE ([Root_Cause_Grp_Cd]=' + RootCauseGroup + ') ;

Joxin Stanly · Answer

try this (some apostrophes were missing) command.CommandText = INSERT INTO [Root_Cause_Grp_Cd_Lookup]([Root_Cause_Grp_Cd][Root_Cause_Grp_Cd_Desc]) Values (' + RootCauseGroup + '' + RootCauseGroupDescription + ') ;

Vignesh Kumar · Answer

Hi Joxin This is the error message I got when I debug.

Joxin Stanly · Answer

Hi frankly i couldn't any issue in your insert query. can you please check if it is throwing some error? if yes please paste the error here..

Vignesh Kumar · Answer

Hi Joxin Update is fine now. I am not able to insert data to the grid now. I am having problem with my insert query. command.CommandText = INSERT INTO [Root_Cause_App_Rsn_Lookup]([Root_Cause_Grp_Cd][Root_Cause_App_Rsn_Cd][Root_Cause_App_Rsn_Desc]) Values(' + RootCauseGroup + '' + RootCauseAppReason + ' ' + RootCauseAppReasonDescription + ') ; command.CommandText = INSERT INTO [Root_Cause_Grp_Cd_Lookup]([Root_Cause_Grp_Cd][Root_Cause_Grp_Cd_Desc]) Values ( + RootCauseGroup + ' + RootCauseGroupDescription + ') ;

Vignesh Kumar · Answer

Hi Below is my table structure CREATE TABLE [dbo] . [Root_Cause_App_Rsn_Lookup] ( [Root_Cause_Group_Cd] [char] ( 3 ) NOT NULL [Root_Cause_App_Rsn] [char] ( 3 ) NOT NULL [Root_Cause_App_Rsn_Desc] [varchar] ( 50 ) NOT NULL PRIMARY KEY CLUSTERED ( [Root_Cause_Group_Cd] ASC  [Root_Cause_App_Rsn] ASC ) WITH ( PAD_INDEX = OFF  STATISTICS_NORECOMPUTE = OFF  IGNORE_DUP_KEY = OFF  ALLOW_ROW_LOCKS = ON  ALLOW_PAGE_LOCKS = ON ) ON [PRIMARY] ) ON [PRIMARY] GO SET GO ANSI_PADDING OFF

Joxin Stanly · Answer

still not clear on your requirement but you can try below -: UPDATE [Root_Cause_App_Rsn_Lookup] SET [Root_Cause_Grp_Cd]=' + RootCauseGroup + ' [Root_Cause_App_Rsn_Cd]=' + RootCauseAppReason + ' [Root_Cause_App_Rsn_Desc]=' + RootCauseAppReasonDescription + ' WHERE ([Root_Cause_Grp_Cd]= ' + RootCauseGroup +' and [Root_Cause_App_Rsn_Cd]= ' + RootCauseAppReason +'); instead of above code i think the better code is below (becos you dont need to update the columns specified in where clause)-: UPDATE [Root_Cause_App_Rsn_Lookup] SET [Root_Cause_App_Rsn_Desc]=' + RootCauseAppReasonDescription + ' WHERE ([Root_Cause_Grp_Cd]= ' + RootCauseGroup +' and [Root_Cause_App_Rsn_Cd]= ' + RootCauseAppReason +');

Sanjeeb Lenka · Answer

HI  plz share your database table structure which you want to update.

Vignesh Kumar · Answer

Hi Joxin I am trying to update Root_Cause_App_Rsn_Desc along with Root_Cause_Grp_Cd. The thing is I amnot sure of the where clause conditions like we use 'where' and 'and' in the query condition whichi will have 2 columns (and these two are primary key columns)

Joxin Stanly · Answer

Hi vignesh in the update scenario are you looking for updating ' [Root_Cause_App_Rsn_Desc] ' only?? because i can see columns to update are also specified in where condition too.. am i missing something here?

Vignesh Kumar · Answer

Hi Sanjeeb I need to add one more column after where clause Root_Cause_App_Rsn_Cd this one. Where Root_Cause_Grp_Cd and Root_Cause_App_Rsn_Cd are primary keys. Can you help me with the query. I am using this to update rows in grid. Also I do have problem with my isnert query too. I am not able to add datas to the grid. command.CommandText = INSERT INTO [Root_Cause_App_Rsn_Lookup]([Root_Cause_Grp_Cd][Root_Cause_App_Rsn_Cd][Root_Cause_App_Rsn_Desc]) Values(' + RootCauseGroup + '' + RootCauseAppReason + ' ' + RootCauseAppReasonDescription + ') ;

Joxin Stanly · Answer

Hi either you can try Sanjeeb method or you can also try this UPDATE [Root_Cause_App_Rsn_Lookup] SET [Root_Cause_Grp_Cd]=' + RootCauseGroup + ' [Root_Cause_App_Rsn_Cd]=' + RootCauseAppReason + ' [Root_Cause_App_Rsn_Desc]=' + RootCauseAppReasonDescription + ' WHERE (Root_Cause_Grp_Cd= ' + RootCauseGroup +');

Sanjeeb Lenka · Answer

Hi try this command.CommandText =UPDATE [Root_Cause_App_Rsn_Lookup] SET [Root_Cause_Grp_Cd]=' + RootCauseGroup + ' [Root_Cause_App_Rsn_Cd]=' + RootCauseAppReason + ' [Root_Cause_App_Rsn_Desc]=' + RootCauseAppReasonDescription + ' WHERE [Root_Cause_Grp_Cd] = ' + RootCauseGroup + ');