Need to replace a line in an Array list

Question

I have an application that reads and imports HTML credit reports, and every so often the html source changes. I am using StringReader and StreamWriter functions to read the report, and if the line has changed, the StreamWriter replaces the changed line with the line that makes the importer properly function.

I have isolated the issue down to manually removing 1 line in the report source code. When this line is removed the report imports successfully.

The line that makes the importer properly function is:
<div id="container"><div id="content" width="760px"> (DOES WORK)

Recently that line has changed to:

<div id="container"><div id="content"> (DOESNT WORK)

The error message received when importing the DOESNT WORK line is:Object reference not set to an instance of an object.

I have uploaded the section of code that handles the importer click
to import function

Any help would be greatly appreciated.

Thanks

Vulpes · Answer

The using statement for the StreamReader should be left as it was. It's only the using statement for the StreamWriter that needs altering as I set out in my previous post. The idea is to close the file before you open it again with this line: ImportResult importResult = handler.Import(destinationDocPaththis.fldDefaultRoundSpin.Value.ToString());

srod srod · Answer

Awesome man! It worked and fixed the problem. I had to add a replace statement in the StreamReader looking for : tmpLine = tmpLine.Replace(  ); tmpLine = tmpLine.Replace(  ); I couldnt get it to work without adding these in addition to following your sugesstions for the StreamWriter function. I also had to add 2 if statement in the StremWriter statement as follows: if (items[i].ToString() !=  ) { if (items[i].ToString() !=  ) { { writer.WriteLine(items[i].ToString()); } // writer.Write(lineToWrite.ToString()); } Your help is very much appreciated. :)

srod srod · Answer

Thanks for the update. Im not quite sure I understand. The first using statement is ended and the second using statement was started. I tried your suggestion the best I understood how and got this error: Object reference not set to an instance of an object What I changed from your suggestion is in red: private void btnImportFile_Click(object sender ImageClickEventArgs e) { try { IImportModule handler = this.GetImportModule(); string documentPath = this.Server.MapPath(this.ResolveUrl(this.UploadFile.PathLocation)); string destinationDocPath = documentPath; if (handler.GetType().FullName == MySite.ReportImporter.MyCreditReportType) { destinationDocPath = documentPath.Replace(.htm _r.htm); System.Collections.ArrayList items = new System.Collections.ArrayList(); string tmpLine; //READ string search =  ; string replacement =  ; using (StreamReader reader = new StreamReader(documentPath)) using (StreamWriter writer = new StreamWriter(destinationDocPath)) { //MODIFY LINE BY LINE WHILE READING while ((tmpLine = reader.ReadLine()) != null) { while ((tmpLine = reader.ReadLine()) != null) { tmpLine = tmpLine.Replace(search replacement); items.Add(tmpLine); } for (int i = 0; i { writer.WriteLine(items[i].ToString()); } } } } ImportResult importResult = handler.Import(destinationDocPaththis.fldDefaultRoundSpin.Value.ToString()); if (importResult.Success) { this.ImportAccounts = importResult.Item; this.CurrentPage = 0; this.BindReviewAccounts(); this.mv.SetActiveView(this.vwReviewImport); if (!CommonUtility.IsNullOrEmpty(importResult.FailedRecords)) { this.grdRecordErrors.DataSource = importResult.FailedRecords; this.grdRecordErrors.DataBind(); } } else { this.SetError(importResult.FriendlyMessage); } } catch (Exception ex) { SiteLog.LogError(ex); this.SetError(An error occurred importing your file. Please ensure the file is complete and try again.); } }

Vulpes · Answer

Yes it looks like this line is trying to reopen the file at destinationDocPath before it's been closed by the using statement which will cause the exception you're seeing: ImportResult importResult = handler.Import(destinationDocPath this.fldDefaultRoundSpin.Value.ToString()); This line and the following code therefore needs to be removed from the using statement: using (StreamWriter writer = new StreamWriter(destinationDocPath)) { for (int i = 0; i { writer.WriteLine(items[i].ToString()); } } // end using ImportResult importResult = handler.Import(destinationDocPaththis.fldDefaultRoundSpin.Value.ToString()); // etc

srod srod · Answer

The entire second using statement is below: using (StreamWriter writer = new StreamWriter(destinationDocPath)) { for (int i = 0; i { { { writer.WriteLine(items[i].ToString()); } } ImportResult importResult = handler.Import(destinationDocPath this.fldDefaultRoundSpin.Value.ToString() ); if (importResult.Success) { this.ImportAccounts = importResult.Item; this.CurrentPage = 0; this.BindReviewAccounts(); this.mv.SetActiveView(this.vwReviewImport); if (!CommonUtility.IsNullOrEmpty(importResult.FailedRecords)) { this.grdRecordErrors.DataSource = importResult.FailedRecords; this.grdRecordErrors.DataBind(); } } else { this.SetError(importResult.FriendlyMessage); } } } } catch (Exception ex) { SiteLog.LogError(ex); this.SetError(An error occurred importing your file. Please ensure the file is complete and try again.); } } Thanks!

Vulpes · Answer

Shane The error message suggests that you've opened that file in another program perhaps in an HTML viewer or editor. However from the code you've posted I can't see the end of the second 'using' statement so it's possible that you might be doing something in there - before the file is closed - that is causing the error.

Sam Hobbs · Answer

You are not using the DOM to parse the HTML. I just got through writing a reply to another thread about using the DOM; it might help you too (look at the other thread). In that thread I linked to my article on the subject. Using the DOM might make your code immune to minor changes such as you are plagued with. Note that the reason I am not saying more is that you obviously have a lot of time invested in the solution you have and I assume you are not inerested in doing it another way.

srod srod · Answer

Thanks. I replace the code and now am getting the following error: Normal 0 false false false EN-US X-NONE X-NONE /* Style Definitions */ table.MsoNormalTable{mso-style-name:Table Normal;mso-tstyle-rowband-size:0;mso-tstyle-colband-size:0;mso-style-noshow:yes;mso-style-priority:99;mso-style-qformat:yes;mso-style-parent:;mso-padding-alt:0in 5.4pt 0in 5.4pt;mso-para-margin:0in;mso-para-margin-bottom:.0001pt;mso-pagination:widow-orphan;font-size:11.0pt;font-family:Calibrisans-serif;mso-ascii-font-family:Calibri;mso-ascii-theme-font:minor-latin;mso-fareast-font-family:Times New Roman;mso-fareast-theme-font:minor-fareast;mso-hansi-font-family:Calibri;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:Times New Roman;mso-bidi-theme-font:minor-bidi;} Method Name: WinIOError Declaring Type: System.IO.__Error Message: The process cannot access the file 'C:\Directory\Site\Files\Uploads\uniquecustid\SAMPLE REPORT_r.htm' because it is being used by another process. Could this be because the importer is already running the following function? destinationDocPath = documentPath.Replace(.htm _r.htm); thanks

Vulpes · Answer

OK in that case I'd try: System.Collections.ArrayList items = new System.Collections.ArrayList(); string tmpLine; //READ string search =  ; string replacement =   using (StreamReader reader = new StreamReader(documentPath)) { //MODIFY LINE BY LINE WHILE READING while ((tmpLine = reader.ReadLine()) != null) { tmpLine = tmpLine.Replace(search replacement); items.Add(tmpLine); } } //WRITE using (StreamWriter writer = new StreamWriter(destinationDocPath)) { for (int i = 0; i { writer.WriteLine(items[i].ToString()); } }

srod srod · Answer

Thanks for the reply. The reason is because the credit report source file no longer has the following line in the source file which makes the credit report importer function correctly:  ---If this line is in the source code of the report the importer works. (THE CREDIT REPORT PROVIDER REMOVED THIS LINE SEVERAL MONTH AGO. WE ADDED THE STREAMREADER FUNCTION TO ADD THE ABOVE LINE BACK IN THE SOURCE FILE BEFORE IMPORTING THE REPORTS) This technique worked up until the credit report provider added the below new line to their report source files. The new line of source that the credit report provider added to their reports is  ---The importer will not import the reports since this line has been added to their source file. When removed from the source file the importer will import the report successfully. I am trying to have the reader look for  and then replace it with either the line  which works or it could just remove the line that doesn't work . The importer will work with  added but if the  is also appearing in the credit report source file it has to be removed to make the importer work. thanks

Vulpes · Answer

I'm not entirely clear what you're doing here but one thing I've noticed is that the following lines are not actually doing anything: tmpLine.Replace(  ); tmpLine.Replace(  ); To modify tmpline you need to assign the results back to that variable: tmpline = tmpLine.Replace(  ); tmpline = tmpLine.Replace(  ); Having removed these strings before adding them to 'items' I didn't then understand why you were double-checking that they weren't there before writing the relevant lines to the destination file?

srod srod · Answer

Sorry the code piece I uploaded did not upload for some reason. The piece of code that handles this import click is: private void btnImportFile_Click(object sender ImageClickEventArgs e) { try { IImportModule handler = this.GetImportModule(); string documentPath = this.Server.MapPath(this.ResolveUrl(this.UploadFile.PathLocation)); //modified 8/3/2011 string destinationDocPath = documentPath; //DO THIS ONLY IF TRUECREDIT if (handler.GetType().FullName == MySite.ReportImporter.ReportModel) { //modified 8/1/2011 - modify source document prior to load destinationDocPath = documentPath.Replace(.htm _r.htm); //StringBuilder lineToWrite = new StringBuilder(); System.Collections.ArrayList items = new System.Collections.ArrayList(); string tmpLine; int numLines = 0; //READ using (StreamReader reader = new StreamReader(documentPath)) { //MODIFY LINE BY LINE WHILE READING while ((tmpLine = reader.ReadLine()) != null) { tmpLine.Replace(  ); tmpLine.Replace(  ); //lineToWrite.Append(tmpLine); items.Add(tmpLine); numLines++; } } int finalLines = numLines; //WRITE using (StreamWriter writer = new StreamWriter(destinationDocPath)) { for (int i = 0; i { if (items[i].ToString() !=  ) { if (items[i].ToString() !=  ) { { writer.WriteLine(items[i].ToString()); } // writer.Write(lineToWrite.ToString()); } }

Vulpes · Answer

Shane You've omitted to upload the code so we can have a look at this.