Closing database connection from destructor

Question

Normal 0 false false false EN-US X-NONE X-NONE /* Style Definitions */ table.MsoNormalTable{mso-style-name:Table Normal;mso-tstyle-rowband-size:0;mso-tstyle-colband-size:0;mso-style-noshow:yes;mso-style-priority:99;mso-style-parent:;mso-padding-alt:0in 5.4pt 0in 5.4pt;mso-para-margin-top:0in;mso-para-margin-right:0in;mso-para-margin-bottom:10.0pt;mso-para-margin-left:0in;line-height:115%;mso-pagination:widow-orphan;font-size:11.0pt;font-family:Calibrisans-serif;mso-ascii-font-family:Calibri;mso-ascii-theme-font:minor-latin;mso-hansi-font-family:Calibri;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:Times New Roman;mso-bidi-theme-font:minor-bidi;} I'm trying to determine if it is acceptable to close the connection to a database in a class' destructor. My understanding is that I have no control over when the destructor is closed but can I at least be certain that it will be closed by the time the program finishes executing. This is a small desktop application that connects to a local jet database. If it matters I am using OleDb.

Vulpes · Answer

A better idea would be for your class to implement the IDisposable interface. You can then call the Dispose() method to close the database connection or by wrapping code in a 'using' statement have this done automatically when the statement ends. This would ensure that the connection is closed immediately rather than waiting for the garbage collector to get around to calling the destructor. There is in fact a 'Disposable' pattern you can use where if you forget to call the Dispose() method the destructor would close the connection before the object is finally destroyed. Check out: http://msdn.microsoft.com/en-us/library/system.idisposable.aspx

Senthilkumar · Answer

Hi There are many ways to close the database connection. It may be in finally block or destructor or using But i suggest you to implement this in 'using' block. using(SqlConnection sqlConnection = new SqlConnection(sqlConnStr)) { } The above using block will automatically handle the object release.

Sam Hobbs · Answer

Probably a better soution would be to not keep the connection open for a long time. Close the connection after processing is done if there will be a delay before it is needed again. There are many good reasons for that. A good way to do that is to use Typed Datasets and then .Net does it for you. A Typed Dataset would either be a TableAdapter or the Entity Framework. They will handle opening and losing connections automatically.

Christopher Yellick · Answer

Thanks Vulpes that's exactly what I was looking for.