Inter-Class Communication

Question

Hello folks I am having a problem in my program that has apparently no reason to show itself but somehow it is. It actually comes when i run the program using F5 key the program doesn't work properly while I execute it step by step using F11 key it works perfectly fine. Well here is my problem. frm_Login obj = new frm_Login(); username = obj.getUsername(); lbl_Welcome.Text = Welcome +username; This given code is placed in another class but when i call it doesn't work. The code of the function getUsername() is as given below public string getUsername() { SqlConnection con = new SqlConnection(Properties.Settings.Default.ConnectionStr); string getCurrentUsername = select User_Name from tblSecUsers where User_ID = '+tbx_UserID.Text+'; con.Open(); SqlCommand cmd = new SqlCommand(getCurrentUsername con); SqlDataReader reader = null; reader = cmd.ExecuteReader(); while (reader.Read()) { username = reader[User_Name].ToString(); } con.Close(); return username; } Urgent help required fellows. Regards.

Jaish Mathews · Answer

Hi But I am seeing one possible problem here. Nomally using any Reader object should be closed manually rather than waiting for CLR. Pleasae use the using block like below using ( SqlConnection con = new SqlConnection ( > ) { //All code here. } NB: Publish the actual code here. The code you published may not compile.. :)

Sam Hobbs · Answer

That is impossible. Either getUsername returns a value or it does not. In C# it is impossible for a function executed in the same source code line to return a value sometimes but not some other time.

theLizard · Answer

Then what does F11 do that F5 does not?

Farrukh Javeid · Answer

lolz.... my bad..... what i meant was the function getUsername() wont return a value in the other class! It does return when executing it through F11 key but wont do it when i hit the F5 key. Sorry again!

Sam Hobbs · Answer

Usually when saying things such as  doesn't work  it is necessary to clarify. Since you don't say what doesn't work nor do you say what happens instead it is unlikely anyone knows why it doesn't work.

Farrukh Javeid · Answer

thanx fellows... thanx for the replies but what exactly triggers the fault while running the program using F5 key or F11 key?

Amit Choudhary · Answer

hi friend SqlConnection con = new SqlConnection(Properties.Settings.Default.ConnectionStr); string getCurrentUsername = select User_Name from tblSecUsers where User_ID = '+tbx_UserID.Text+'; con.Open(); SqlCommand cmd = new SqlCommand(getCurrentUsername con); username=cmd.ExecuteScalar().ToString(); con.Close(); return username; The ExecuteScalar function return only one record. you can use it if only one record from the database is expected.

theLizard · Answer

There is a reason for everything... SqlDataReader reader = cmd.ExecuteReader(); how many users to you expect out of the database! using while is pointless use if(reader.Read()) instead. you have declared username before the function but you have not sent it to the function so how can you return username if it is not declared? you should not even be able to compile... using tbx_UserID.Text directly is dangerouse this is how sql injection attacks work you need to use parameters.