More logic behind the game

Question

I updated the form http://www.4shared.com/rar/0gXAY4w7/LetItRide.html
I see a lot of different bugs in my game.
But the main thing is when the last two cards displayed(cardDealer1 and cardDealer2) the game either subtracts or adds the money. But how would I display second round of cards, and 3rd and 4th( you know what I mean)? Just like in this game http://www.freepoker.com/free-let-em-ride-poker

When you click continue two times, it should either let you rebet ( new round) or select new bet.
Vulpes, I did send you the info to log in to my 4shared, so you dont have to wait

Vulpes · Answer

It looks like you've got company: http://www.c-sharpcorner.com/Forums/Thread/163093/passing-values-from-one-form-to-another-form.aspx Anyway I've been playing the free online poker game and the first thing I noticed is that after a game has been completed a label pops up to tell you what your hand was - pair of 7s Ace High etc and whether the player or the house won. There was no way that we could reproduce that as the code in the Hand class stood so I've rewritten it so that we now have the necessary information to pop up a messagebox (you can use a label if you prefer): public class Hand { private List hand; public List CardsInHand { get { if (this.IsComplete()) { return hand; } else { return null; // Gotta see chapter 11! } } } public int Count { get { return hand.Count; } } public bool IsComplete() { return hand.Count >= 5; } public void Sort() { hand.Sort(); } public void Dispose() { hand.Clear(); } public Hand() { hand = new List (); } public void AddCard(GraphicalCard card) { if (!this.IsComplete()) { hand.Add(card); } else { //see chapter 11 } } private static string[] cn = { 2 3 4 5 6 7 8 9 10 Jack Queen King Ace }; public HandType DetermineHandByType(out string description) { HandType result = HandType.NOTHING; if (!IsComplete()) { description = Hand is incomplete; return result; } int[] cardCounts = new int[13]; // all zero initially foreach (GraphicalCard card in hand) cardCounts[card.GetNumericValue() - 2]++; int value = -1; int pair = -1; for (int i = 0; i { if (cardCounts[i] == 1) { if ((result == HandType.NOTHING) && (i > value)) value = i; } else if (cardCounts[i] == 2) { if (result == HandType.NOTHING) { result = HandType.TENS_OR_BETTER; value = -1; pair = i; } else if (result == HandType.TENS_OR_BETTER) { description = String.Format(Two Pairs
{0}s and {1}s
Player wins cn[i] cn[pair]); return HandType.TWO_PAIRS; } else if (result == HandType.THREE_OF_A_KIND) { description = String.Format(Full House
{0}s and {1}s
Player wins cn[value] cn[i]); return HandType.FULL_HOUSE; } } else if (cardCounts[i] == 3) { if (result == HandType.NOTHING) { result = HandType.THREE_OF_A_KIND; value = i; } else if (result == HandType.TENS_OR_BETTER) { description = String.Format(Full House
{0}s and {1}s
Player wins cn[i] cn[pair]); return HandType.FULL_HOUSE; } } else if (cardCounts[i] == 4) { description = String.Format(Four {0}s
Player wins cn[i]); return HandType.FOUR_OF_A_KIND; } } if (result == HandType.THREE_OF_A_KIND) { description = String.Format(Three {0}s
Player wins cn[value]); return result; } else if (result == HandType.TENS_OR_BETTER) { if (pair >= 8) { description = String.Format(Pair of {0}s
Player wins cn[pair]); return result; } else { description = String.Format(Pair of {0}s
House wins cn[pair]); return HandType.NOTHING; } } int first; string suit; if(IsRoyalFlush(out first out suit)) { description = String.Format(Royal Flush in {0}
10 to Ace
Player wins suit); return HandType.ROYAL_FLUSH; } else if(IsStraightFlush(out first out suit)) { description = String.Format(Straight Flush in {0}
{1} to {2}
Player wins suit cn[first] cn[first + 4]); return HandType.STRAIGHT_FLUSH; } else if(IsFlush(out suit)) { description = String.Format(Flush in {0}
Player wins suit); return HandType.FLUSH; } else if(IsStraight(out first)) { description = String.Format(Straight {0} to {1}
Player wins cn[first] cn[first + 4]); return HandType.STRAIGHT; } description = String.Format({0} High
House Wins cn[value]); return result; } private bool IsRoyalFlush(out int first out string suit) { return IsStraightFlush(out first out suit) && hand[4].FaceValue == Ace;/* && Is there an Ace? */; } private bool IsStraightFlush(out int first out string suit) { bool isFlush = IsFlush(out suit); return IsStraight(out first) && isFlush; } private bool IsFlush(out string suit) { suit = hand[0].Suit; for (int index = 1; index { if (hand[index].Suit != suit) return false; } return true; } private bool IsStraight(out int first) { int prev = hand[0].GetNumericValue(); first = prev - 2; for (int index = 1; index { int next = hand[index].GetNumericValue(); if ((next - prev) != 1) return false; prev = next; } return true; } } You'll notice that the DetermineHandByType() method is now doing most of the work (and has acquired an 'out' parameter to describe the result) and a number of the previous methods have been eliminated and the others changed slightly. You need to make some changes to the Game.PayOutMoney method to accomodate the above: public void PayOutMoney() { int payOut = 0; int betAmount = player.GetBetAmount(); string description; switch (player.Hand.DetermineHandByType(out description)) { case HandType.NOTHING: //payOut = -betAmount; // bet already deducted //pay the dealer break; case HandType.TENS_OR_BETTER: payOut = betAmount * 1; break; case HandType.TWO_PAIRS: payOut = betAmount * 2; break; case HandType.THREE_OF_A_KIND: payOut = betAmount * 3; break; case HandType.STRAIGHT: payOut = betAmount * 5; break; case HandType.FLUSH: payOut = betAmount * 8; break; case HandType.FULL_HOUSE: payOut = betAmount * 11; break; case HandType.FOUR_OF_A_KIND: payOut = betAmount * 50; break; case HandType.STRAIGHT_FLUSH: payOut = betAmount * 200; break; case HandType.ROYAL_FLUSH: payOut = betAmount * 1000; break; } //Add (or subtract) the bet amount from the players cash. player.Money += payOut; gui.DisplayPlayerMoney(player.Money); System.Windows.Forms.MessageBox.Show(description); //or... // int payout = player.DetermineHand(); //betAmount * payout : is what the player gets... } Another thing I've noticed that the online game doesn't feature the bet ranges which yours does. However your lowest range 5 to 25 dollars doesn't really make sense when you allow a $1 bet. Perhaps it would be better to change this range to 1 to 25 dollars. Basically you need to reset the game (apart from the player's money) before each new deal but before we come to that I'd make the above changes first.

Prime b · Answer

Also the bet range is not me its my teacher its one of his requirements. lol I would love not to implement it less headache Normal 0 false false false EN-US X-NONE X-NONE /* Style Definitions */ table.MsoNormalTable{mso-style-name:Table Normal;mso-tstyle-rowband-size:0;mso-tstyle-colband-size:0;mso-style-noshow:yes;mso-style-priority:99;mso-style-parent:;mso-padding-alt:0in 5.4pt 0in 5.4pt;mso-para-margin-top:0in;mso-para-margin-right:0in;mso-para-margin-bottom:10.0pt;mso-para-margin-left:0in;line-height:115%;mso-pagination:widow-orphan;font-size:11.0pt;font-family:Calibrisans-serif;mso-ascii-font-family:Calibri;mso-ascii-theme-font:minor-latin;mso-hansi-font-family:Calibri;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:Times New Roman;mso-bidi-theme-font:minor-bidi;} User Story: The user will start the game. Upon game start the user will be given a random amount of money. This amount will be between $100-1000. The user will then choose from three different betting limits (minimum bet – maximum bet) $5-100 $25-500 and $50-1000. The user will then begin the game loop you can read the requirements here http://www.4shared.com/file/6H4yor8c/c_charp_project_2_requirements.html?refurl=d1url Updated form here http://www.4shared.com/rar/cAsHisJq/LetItRide.html

Prime b · Answer

I tested everything works perfectly sucks that code wasn't needed //private bool IsRoyalFlush() //{ // return IsStraightFlush() && hand[4].FaceValue == Ace;/* && Is there an Ace? */; //} //private bool IsStraightFlush() //{ // return IsStraight() && IsFlush(); //} //private bool IsFourOfKind() //{ // return (hand[0].FaceValue == hand[3].FaceValue) || (hand[1].FaceValue == hand[4].FaceValue); //} //private bool IsFullHouse() //{ // return ((hand[0].FaceValue == hand[1].FaceValue) && (hand[2].FaceValue == hand[4].FaceValue)) || // ((hand[0].FaceValue == hand[2].FaceValue) && (hand[3].FaceValue == hand[4].FaceValue)); //} //private bool IsFlush() //{ // string suit = hand[0].Suit; // for (int index = 1; index // { // if (hand[index].Suit != suit) return false; // } // return true; //} //private bool IsStraight() //{ // int prev = hand[0].GetNumericValue(); // for (int index = 1; index // { // int next = hand[index].GetNumericValue(); // if ((next - prev) != 1) return false; // prev = next; // } // return true; //} //private bool IsThreeOfAkind() //{ // return (hand[0].FaceValue == hand[2].FaceValue) // || (hand[1].FaceValue == hand[3].FaceValue) // || (hand[2].FaceValue == hand[4].FaceValue); //} //private bool isTwoPairs() //{ // return ((hand[0].FaceValue == hand[1].FaceValue) && (hand[2].FaceValue == hand[3].FaceValue)) // || ((hand[0].FaceValue == hand[1].FaceValue) && (hand[3].FaceValue == hand[4].FaceValue)) // || ((hand[1].FaceValue == hand[2].FaceValue) && (hand[3].FaceValue == hand[4].FaceValue)); //} //private bool IsTensOrBetter() //{ // return ((hand[0].FaceValue == hand[1].FaceValue) && hand[0].GetNumericValue() >= 10) // || ((hand[1].FaceValue == hand[2].FaceValue) && hand[1].GetNumericValue() >= 10) // || ((hand[2].FaceValue == hand[3].FaceValue) && hand[2].GetNumericValue() >= 10) // || ((hand[3].FaceValue == hand[4].FaceValue) && hand[3].GetNumericValue() >= 10); //} and //Sort(); //if (IsRoyalFlush()) //royal flush //{ // result = HandType.ROYAL_FLUSH; //} //else if (IsStraightFlush()) // Straight Flush //{ // result = HandType.STRAIGHT_FLUSH; //} //else if (IsFourOfKind()) //Four of a Kind //{ // result = HandType.FOUR_OF_A_KIND; //} //else if (IsFullHouse()) // Full House //{ // result = HandType.FULL_HOUSE; //} //else if (IsFlush()) // Flush //{ // result = HandType.FLUSH; //} //else if (IsStraight()) // Straight //{ // result = HandType.STRAIGHT; //} //else if (IsThreeOfAkind()) // Three of a Kind //{ // result = HandType.THREE_OF_A_KIND; //} //else if (isTwoPairs()) //two of a Kind //{ // result = HandType.TWO_PAIRS; //} //else if (IsTensOrBetter()) //10s or better //{ // result = HandType.TENS_OR_BETTER; //} //return result;

Prime b · Answer

Vulpes thank you!

Prime b · Answer

Ah ok well talk to you tomorrow then! I also don't play card games I actually never played to card game before in my life( parent issues as I already told Sam ) so hopefully he wont assign anymore card games which he said he wont! Well teacher told me not to worry about multiple players. The play is the only player and he is playing against himself i guess? But here is one links for the rules so you don't have to look for them: http://www.coolcat-casino.com/table-games/let-em-ride.php http://www.letstalkwinning.com/Let-It-Ride.htm http://www.letitride.org/rules/ I think 3 links is enough what else do you need tell me also I attached the requirements and you can see the in 4share

Vulpes · Answer

I'll need to read the rules of the game (I don't play online poker) and look at the program as a whole to be able to advise on that but as it's past midnight here I'll have to leave that till tomorrow if no-one else has responded in the meantime. Incidentally your game appears to be allowing for multiple players but the one you're trying to copy only seems to allow for one?