repetitive data in combobox selection

Question

hello i created an interface that will select data from 2 tables using 2 seperate combobox. the problem is that  my code returned repetitive data....pls refer below for the ist combobox it shows; cd-r cd-r cd-r cd-r cd-rw cd-rw cd-rw cd-rw for the 2nd combobox - - - same thing happened Could someone help me with my code; Private Sub WTransaksi1_Load(ByVal sender As System.Object ByVal e As System.EventArgs) Handles MyBase.Load strSQL = SELECT DISTINCT Customer_Transaction.Test_DiscName Customer_Transaction.Date_transaction Model_Transaction.Model_Name FROM Customer_Transaction Model_Transaction ORDER BY Customer_Transaction.Test_DiscName Customer_Transaction.Date_transaction ASC oledbcon.Open() Dim cmd As New OleDbCommand(strSQL oledbcon) Dim objreader As OleDbDataReader = cmd.ExecuteReader() Do While objreader.Read() ComboBox1.Items.Add(objreader(Test_DiscName)) ComboBox2.Items.Add(objreader(Model_Name)) Loop oledbcon.Close() Call data_bind() End Sub thanks in advance! bitoy

arthur.javier · Answer

hello craig I just wanted to say thank you for your time it is greatly appreciated. your right it was resolved by calling a seperate procedure (data_bind). but i have one more problem i created a program in 1 form (upon button click) that are able to update one table and at the same time able to insert data to other table. but the problem is it can't update data  only insert data is functioning. please check my code below; Private Sub WTransaksi2_Load(ByVal sender As System.Object ByVal e As System.EventArgs) Handles MyBase.Load Call Load1() Call load2() End Sub Private Sub Load1() strSQL = SELECT Test_DiscName Date_transaction FROM Customer_Transaction ORDER BY Test_DiscName Date_transaction ASC oledbcon.Open() Dim cmd As New OleDbCommand(strSQL oledbcon) Dim objreader As OleDb.OleDbDataReader = cmd.ExecuteReader() Do While objreader.Read() ComboBox1.Items.Add(objreader(Test_DiscName)) Loop oledbcon.Close() Call data_bind() End Sub Private Sub load2() strSQL = SELECT Model_Name FROM Model_Transaction oledbcon.Open() Dim cmd As New OleDbCommand(strSQL oledbcon) Dim objreader As OleDbDataReader = cmd.ExecuteReader() Do While objreader.Read() ComboBox2.Items.Add(objreader(Model_Name)) Loop oledbcon.Close() Call data_bind1() End Sub Private Sub data_bind() strSQL = SELECT * FROM Customer_Transaction Dim cmd As New OleDbCommand(strSQL oledbcon) da = New OleDbDataAdapter(cmd) ds = New DataSet da.Fill(ds Customer_Transaction) If BindingContext(ds Customer_Transaction).Position < 0 Then MsgBox(Database Is Empty ! MsgBoxStyle.Information Test Disc System) Exit Sub End If End Sub Private Sub data_bind1() strSQL = SELECT * FROM Model_Transaction Dim cmd As New OleDbCommand(strSQL oledbcon) da = New OleDbDataAdapter(cmd) ds = New DataSet da.Fill(ds Model_Transaction) If BindingContext(ds Model_Transaction).Position < 0 Then MsgBox(Database Is Empty ! MsgBoxStyle.Information Test Disc System) Exit Sub End If End Sub Private Sub ComboBox1_SelectedIndexChanged(ByVal sender As System.Object ByVal e As System.EventArgs) Handles ComboBox1.SelectedIndexChanged strSQL = SELECT * FROM Customer_Transaction WHERE Test_DiscName= ' & ComboBox1.Text & ' oledbcon.Open() Dim cmd As New OleDbCommand(strSQL oledbcon) Dim objReader As OleDbDataReader = cmd.ExecuteReader() objReader.Read() TextBox2.Text = objReader(Inventory) TextBox6.Text = objReader(HoldingDays) TextBox4.Text = objReader(Unit_price) TextBox5.Text = objReader(Total) DateTimePicker1.Text = objReader(Date_transaction) TextBox7.Text = objReader(DailyConsumption) objReader.Close() oledbcon.Close() End Sub Private Sub ComboBox2_SelectedIndexChanged(ByVal sender As System.Object ByVal e As System.EventArgs) Handles ComboBox2.SelectedIndexChanged strSQL = SELECT * FROM Model_Transaction WHERE Model_Name= ' & ComboBox2.Text & ' oledbcon.Open() Dim cmd As New OleDbCommand(strSQL oledbcon) oledbcon.Close() End Sub Private Sub Button1_Click(ByVal sender As System.Object ByVal e As System.EventArgs) Handles Button1.Click DateTimePicker1.Value = Date.Now Call Update_Customer_Transaction() Call Insert_CD_Issuance() ask = MsgBox(Do You Want To Withdraw Again ? MsgBoxStyle.YesNo Test Disc System) If ask = vbYes Then Me.Hide() cur = New WTransaksi1 cur.MdiParent = Me.MdiParent cur.Show() ElseIf ask = vbNo Then Me.Close() End If End Sub Private Sub Update_Customer_Transaction() oledbcon.Open() strSQL = UPDATE Customer_Transaction SET  & _ Test_DiscName = ' & ComboBox1.Text & ' Inventory=' & Val((TextBox2.Text) - Val(TextBox8.Text)) & ' HoldingDays=' & TextBox6.Text & ' WHERE Test_DiscName = ' & ComboBox1.Text & ' AND Date_transaction = ' & DateTimePicker1.Value & ' Dim cmd As New OleDbCommand(strSQL oledbcon) cmd.ExecuteNonQuery() oledbcon.Close() End Sub Private Sub Insert_CD_Issuance() strSQL = INSERT INTO CD_Issuance & _ (Test_DiscNameModel_NameWithdrawn_CDDate_transaction)Values & _ (' & ComboBox1.Text & '' & ComboBox2.Text & '' & TextBox8.Text & ' & ' & DateTimePicker1.Value & ') oledbcon.Open() Dim cmd As New OleDbCommand(strSQL oledbcon) cmd.ExecuteNonQuery() MsgBox(Data was Saved Successfully ! MsgBoxStyle.Information Test Disc System) oledbcon.Close() End Sub Private Sub Button2_Click(ByVal sender As System.Object ByVal e As System.EventArgs) Handles Button2.Click Me.Close() End Sub Private Sub TextBox8_TextChanged(ByVal sender As System.Object ByVal e As System.EventArgs) Handles TextBox8.TextChanged On Error GoTo fix 'TextBox1.Text = Val((TextBox1.Text) - Val(TextBox3.Text)) TextBox6.Text = Val((TextBox2.Text) - Val(TextBox8.Text)) / TextBox7.Text 'TextBox6.Text = Val((TextBox2.Text) * Val(TextBox7.Text)) fix: End Sub #End Region End Class Once again thank you for your help... bitoy

cgcomp · Answer

It looks like you manually populate the lists then possibly call a seperate function (data_bind) to do it again: ' 'POPULATING HERE ' Do While objreader.Read() ComboBox1.Items.Add(objreader(Test_DiscName)) ComboBox2.Items.Add(objreader(Model_Name)) Loop oledbcon.Close() ' 'POPULATING HERE? ' Call data_bind() ---- If this is not the solution can you post the code for the data_bind member?