string.insert problem

Question

I am trying to trim s3 off the end of stringToSplit. It splits into the array ok but when i call string.insert() it simply doesn't add anything to newString. here is the code: string stringToSplit = s1/s2/s3; string[] stringArray = stringToSplit.Split('/'); string newString = ; for(int y = 0;y != stringArray.Length - 1;y++) { newString.Insert(newString.LengthstringArray[y].ToString()); }

sacresp · Answer

is string.concat any better?

tsuman_in · Answer

I'm with spoimala. At least use string.Concat.

sacresp · Answer

Concatenating strings is inefficient as string is immutable class use StringBuilder instead ;)

prasad.narwadkar · Answer

I have a few comments on the original code. 1. Using ToString() on a string instance is no good programming technique. ToString() should be used only on non-string objects. 2. Insert() works only if the string to insert into is having sufficient length to accommodate the new resulting string. Use the code below to exactly do what you desire. string stringToSplit = s1/s2/s3; string[] stringArray = stringToSplit.Split('/'); string newString = ; for(int y = 0position = 0;y != stringArray.Length - 1;y++) { newString = newString.Insert(positionstringArray[y]); position = stringArray[y].Length; }

Mahesh Chand · Answer

Sounds good ;)

mreister · Answer

solved problem. i used this. for(int y = 0;y != stringArray.Length - 1;y++) { newSubjectString += /; newSubjectString += stringArray[y]; }