to keep up a score

Question

Hi

I want to keep up a score in the game.

I have this:

[code]

public int Score { get; private set; }

public Invader(Type invaderType, Point location, int score)
{

//this.image = StarInvader2.Properties.Resources.bug1;
this.InvaderType = invaderType;
this.Location = location;
this.Score = score;
this.Score = GameConstants.BugScore;
this.Score = GameConstants.SatelliteScore;
this.Score = GameConstants.SaucerScore;
this.Score = GameConstants.SpaceshipScore;
this.Score = GameConstants.StarScore;
//image = InvaderImageBlock(0);
//SetupImage();
//InvaderImage();

//this.image = InvaderImageBlock[(int)invaderType][0]; //Object is null.
this.image = InvaderImage(0);

}//End constructor.
[/code]

And this are the constants:

[code]
//Invader scores
public const int BugScore = 25;
public const int SaucerScore = 20;
public const int SatelliteScore = 15;
public const int SpaceshipScore = 10;
public const int StarScore = 5;
[/code]

And I have this in the class Game:

[code]
public void gameScore(Graphics g)
{

Font drawfont = new Font("Arial", 16);
g.DrawString(score.ToString(), drawfont, Brushes.White, 10f, 15f);
}
[/code]

I see a white zere in the upper left corner. But If I shoot an invader out of the sky the counter doesn't count.

Thx for helping me.

albert albert · Answer

Oke I tried other approach: Game class: [code] private void InvaderRow(Type invaderTypeint Score int startX int startY) { int currentX = startX; //int currentY = startY; for (int i = 0; i { //Create new invader Point invaderLocation = new Point(currentX startY); Invader newInvader = new Invader( invaderType /* Type.Bug*/ invaderLocation score); //Add it into our list invaders.Add(newInvader); //Add eatch invader to the row currentX += GameConstants.HorizontalInterval; //currentY += GameConstants.VerticalInterval; } }//End method private void InitialPopulateInvaders() { int left = GameConstants.InitialLeft; int fromTop = GameConstants.InvaderVertSpacing; InvaderRow(Type.BugGameConstants.BugScore left fromTop);//First row of invader are type:Bug. fromTop += GameConstants.InvaderVertSpacing; InvaderRow(Type.SaucerGameConstants.SaucerScore left fromTop); fromTop += GameConstants.InvaderVertSpacing; InvaderRow(Type.sateliteGameConstants.SatelliteScore left fromTop); fromTop += GameConstants.InvaderVertSpacing; InvaderRow(Type.SpaceshipGameConstants.SpaceshipScore left fromTop); fromTop += GameConstants.InvaderVertSpacing; InvaderRow(Type.starGameConstants.StarScore left fromTop); fromTop += GameConstants.InvaderVertSpacing; }//End method [/code] and for the GameScore: [code] public void gameScore(Graphics g Invader invader) { Font drawfont = new Font(Arial 16); g.DrawString(invader.Score.ToString() drawfont Brushes.White 10f 15f); } [/code] [code] public void StartGame() { // SetupStartScreen(g); this.playerShip = new PlayerShip(new Point(boundaries.Width / 2 boundaries.Height - 45)); //invader.SetupImage(); InitialPopulateInvaders(); UpdateInvaderCell(animationCell); AnimateObject(); //MoveInvaders(); // MoveInvaderReal(); //invaders.Clear(); playerShots.Clear(); invaderShots.Clear(); this.score = 0; this.wave = 0; } [/code] Still no changing in score :(

albert albert · Answer

HI the reason is that the score is in Game is that because not only the invaders use the score also the starship. But oke. I have now put the call for the score method temporarily in the Invader class like this: [code] public void Draw(Graphics g int animationCell) { g.DrawImage(this.image this.Location); Font drawfont = new Font(Arial 16); g.DrawString(this.Score.ToString() drawfont Brushes.White 10f 15f); }//End method [/code] and the consturctor: [code] public Invader(Type invaderType Point location int score) { //this.image = StarInvader2.Properties.Resources.bug1; this.InvaderType = invaderType; this.Location = location; //this.Score = score; this.image = InvaderImage(0); //ScoreInvader(Score); //gameScore(g); }//End constructor. [/code] But the score is counting back!! and not up. If I shoot all the invaders out of the sky the score dissapear.

Vulpes · Answer

Well I'm confident the score would display correctly if we could work out where the ScoreInvader() method should be called - I couldn't see an obvious location within that method as I couldn't tell which invader(s) are being shot down. You could test it works by going back to the Game.Draw() method and temporarily adding an extra line: if (!gameOver) { playerShip.Draw(g);//Draws the player on the form foreach (Invader invader in invaders) { invader.Draw(g animationCell); //gameScore(g invader); } foreach (Shot shot in playerShots) shot.Draw(g); foreach (Shot shot in invaderShots) shot.Draw(g); foreach (Invader invader in invaders) { invader.ScoreInvader(20); // temporary line for testing gameScore(g invader); } //invader.gameScore(g); } As the project is becoming quite convoluted it might be a good time to review the whole thing from scratch and see if you can do anything to simplify the logic. The way the score is kept certainly needs looking at.

albert albert · Answer

Yes oke. in this piece of code the invaders are shooting down: [code] private void ReturnFire() { if (invaderShots.Count > wave + 1) return; bool playershipDead = false; var InvaderFire = from invader in invaders //where invader.Location.Y //+ invader.image.Width / 2 + invader.image.Height / 2 //where invader.Location.X > boundaries.Right //- 500 //orderby invader.Location.Y descending //select invaderGroup; group invader by invader.Location.Y into invaderGroup select invaderGroup; //KeyValuePair.Of invader; //select new { Value = invaderGroup.Key}; foreach( var invaderColumn in InvaderFire ) { var q = from invader in invaderColumn orderby invader.Location.Y descending select invader; Invader invaderB = q.First(); if (random.Next(14) { Point shotPoint = new Point((invaderB.Location.X + invaderB.image.Width / 2 - 2) (invaderB.Location.Y + invaderB.image.Height)); invaderShots.Add(new Shot(shotPoint Direction.Down this.boundaries)); } //return playershipDead; } }//End met [/code] But still it doesnt work so good. But that can be later. I think if counting for invader workst oke then after we can build for invader shooting back on the space ship. But u are ofcourse right that the in the beginning the score has to be zero.

Vulpes · Answer

What I'm struggling to get my head around is why you'd pass the Invader constructor a 'score' argument because I'd have thought it should be zero at that point? But you also need to call the ScoreInvader() method when the Invader is shot down so we need to know where that occurs in the code.

albert albert · Answer

And I think the swith method is not correct. Because there is always for example an: Type.Bug. and an Type.star.

albert albert · Answer

Hi Vulpes the problem is if I put this: [code] public Invader(Type invaderType Point location int score) { //this.image = StarInvader2.Properties.Resources.bug1; this.InvaderType = invaderType; this.Location = location; this.Score = score; this.image = InvaderImage(0); ScoreInvader(Score); //gameScore(g); }//End constructor. [/code] then if I run(F5) then already the method scoreInvader activate. I put a breakpoint for example at this line: case Type.satelite: Score += GameConstants.SatelliteScore; break; And the compiler stops there before I shut.

Vulpes · Answer

Well I can't find anywhere where the Invader.ScoreInvader() method is actually called which would explain why the score never changes! So if this is correct the next question is where should it be called. So at what point in the code do you know when you've shot down an invader because I haven't been able to figure that one out either?

albert albert · Answer

This is my hole project.

Vulpes · Answer

Where are you calling the ScoreInvader() method from? I thought it must be within shot.Draw() but evidently it isn't.

albert albert · Answer

Hi I have done it exactly like u: [code] public void Draw(Graphics g bool gameOver /*int animationCell*/ ) { stars.Draw(gboundaries);//Draws the stars on the form if (!gameOver) { playerShip.Draw(g);//Draws the player on the form foreach (Invader invader in invaders) { invader.Draw(g animationCell); //gameScore(g invader); } foreach (Shot shot in playerShots) shot.Draw(g); foreach (Shot shot in invaderShots) shot.Draw(g); foreach (Invader invader in invaders) { gameScore(g invader); } //invader.gameScore(g); } else SetupStartScreen(g); // form1.Invalidate();//To redraw part of the form that is dirty.The Refresh() method is: Invalidate() + Update(). }//End method [/code] But still no change in the score.

Vulpes · Answer

You've got the bit which calls the gameScore method in the wrong place: if (!gameOver) { playerShip.Draw(g);//Draws the player on the form foreach (Invader invader in invaders) { invader.Draw(g animationCell); //Draws every invader on the form } foreach (Shot shot in playerShots) shot.Draw(g); foreach (Shot shot in invaderShots) shot.Draw(g); foreach((Invader invader in invaders) { gameScore(g invader); } }

albert albert · Answer

Hi I have now this: [code] public void Draw(Graphics g bool gameOver /*int animationCell*/ ) { stars.Draw(gboundaries);//Draws the stars on the form if (!gameOver) { playerShip.Draw(g);//Draws the player on the form foreach (Invader invader in invaders) { invader.Draw(g animationCell); //Draws every invader on the form } foreach(Invader invader in invaders) { gameScore(g invader); } foreach (Shot shot in playerShots) shot.Draw(g); foreach (Shot shot in invaderShots) shot.Draw(g); //invader.gameScore(g); } else SetupStartScreen(g); // form1.Invalidate();//To redraw part of the form that is dirty.The Refresh() method is: Invalidate() + Update(). }//End method [/code] and for the other method: [code] public void gameScore(Graphics g Invader invader) { Font drawfont = new Font(Arial 16); g.DrawString(invader.Score.ToString() drawfont Brushes.White 10f 15f); } [/code] and for score: [code] public int ScoreInvader(int Score) { switch(InvaderType) { case Type.Bug: //case Type.Bug: Score += GameConstants.BugScore; break; case Type.satelite: Score += GameConstants.SatelliteScore; break; case Type.Saucer: Score += GameConstants.SaucerScore; break; case Type.Spaceship: Score += GameConstants.SpaceshipScore; break; case Type.star: Score += GameConstants.StarScore; break; default: break; } this.Score += Score; return Score; }//End method [/code] it compiles fine but the score is not changing if I shoot an invader out of the sky. :(

Vulpes · Answer

It looks to me as though you should be calling: gameScore(g); within a foreach() loop. The following should work: foreach((Invader invader in invaders) { this.invader = invader; gameScore(g); } though it would be tidier to change the gameScore method so that it takes an additional Invader parameter: foreach((Invader invader in invaders) { gameScore(g invader); } public void gameScore(Graphics g Invader invader) // extra parameter { Font drawfont = new Font(Arial 16); g.DrawString(invader.Score.ToString() drawfont Brushes.White 10f 15f); // now uses parameter instead of field }

albert albert · Answer

I understand. I give u more information. But to make a new Invader class is not good I think. And not necessary I think. This is part of my Game class: [code] using System; using System.Collections.Generic; using System.Linq; using System.Text; using System.Drawing; using System.Windows.Forms; namespace StarInvader2 { public class Game { public const int InvadersRow = 1;//Shows the rows of invaders. Form1 form1; Invader invader; public int score = 0; private int livesLeft = 2; private int wave; private int framesSkipped = 0; private Rectangle boundaries; private Random random; private Bitmap[] starAnimation; private Bitmap[] bugAnimation; private Bitmap[] saucerAnimation; private Bitmap[] sateliteAnimation; private Bitmap shipAnimation; private DateTime lastFireTime; public Boolean beenHit = false; private long TimerCounter = 1; private int TheSpeed = 4; private Direction direction = Direction.Right; int vertPos; private Type invaderType; private Stars stars; private PlayerShip playerShip; private Point Location; private Shot shot; public List starList = new List (); //private Direction invaderDirection; private List invaders = new List (); Graphics g; private int shotNumber; private List playerShots = new List (); private List invaderShots = new List (); private List invaderBombs = new List (); private DateTime? GameOverTime = null; protected Rectangle MovingBounds = new Rectangle(); public event EventHandler GameOver; public Game(Rectangle boundaries /*Invader invader*/ ) { this.boundaries = boundaries; random = new Random(); this.stars = new Stars(boundaries); this.playerShip = new PlayerShip(new Point(boundaries.Width / 2 boundaries.Height - 45)); //this.shot = new Shot(Locationdirection boundaries); lastFireTime = DateTime.Now; invaderShots = new List (); //Invader invader = new Invader(invaderTypeLocation score); this.score = score; } public void StartGame() { // SetupStartScreen(g); this.playerShip = new PlayerShip(new Point(boundaries.Width / 2 boundaries.Height - 45)); //invader.SetupImage(); InitialPopulateInvaders(); UpdateInvaderCell(animationCell); AnimateObject(); //MoveInvaders(); // MoveInvaderReal(); //invaders.Clear(); playerShots.Clear(); invaderShots.Clear(); this.score = 0; this.wave = 0; } public void Go() { bool gameOverFlag = false; MoveInvaderReal(); MoveInvaders(); //Moves the invaders!!yoe hoe!! CheckForInvaderCollision(); CheckInvaderHitsBottum(); //Moveshot(playerShots); MoveAllShots(playerShots); MoveAllShots(invaderShots); // UpdateFireshotPlayer(); ReturnFire(); NextWafe(); //invader.SetupImage(); //AnimateObject(); //InitialPopulateInvaders(); if (gameOverFlag) OnGameOver(); }//End method public void Draw(Graphics g bool gameOver /*int animationCell*/ ) { stars.Draw(gboundaries);//Draws the stars on the form if (!gameOver) { playerShip.Draw(g);//Draws the player on the form foreach (Invader invader in invaders) invader.Draw(g animationCell); //Draws every invader on the form foreach (Shot shot in playerShots) shot.Draw(g); foreach (Shot shot in invaderShots) shot.Draw(g); //invader.gameScore(g); gameScore(g); } else SetupStartScreen(g); // form1.Invalidate();//To redraw part of the form that is dirty.The Refresh() method is: Invalidate() + Update(). }//End method [/code] That is why I am little bit stuck here. Do u have any other suggestions.

Vulpes · Answer

Ah I didn't notice that the gameScore method was in a separate class. So I imagine 'invader' must be a field or property of the Game Class which holds a reference to an Invader object. The error suggests you haven't new'ed this anywhere and so it's still null. I can't really tell you any more than that just now.

albert albert · Answer

Hi Vulpes I understand that class game has to get the property Score in Class Invader. But then it would thus like this: Class: Game: public void gameScore(Graphics g) { Font drawfont = new Font(Arial 16); g.DrawString(this.invader.Score.ToString() drawfont Brushes.White 10f 15f); } But then I get this error: Object reference not set to an instance of an object.

Vulpes · Answer

You need to assign the result to your property so that it's accessible from elsewhere in the class: public int ScoreInvader(int Score) { switch(InvaderType) { case Type.Bug: //case Type.Bug: Score += GameConstants.BugScore; break; case Type.satelite: Score += GameConstants.SatelliteScore; break; case Type.Saucer: Score += GameConstants.SaucerScore; break; case Type.Spaceship: Score += GameConstants.SpaceshipScore; break; case Type.star: Score += GameConstants.StarScore; break; default: break; } this.Score += Score; // EDIT: Probably += return Score; }//End method Then to draw the current score you'll need: g.DrawString( this.Score. ToString() drawfont Brushes.White 10f 15f);

albert albert · Answer

Hi Vulpes I have now this: [code] public int ScoreInvader(int Score) { switch(InvaderType) { case Type.Bug: //case Type.Bug: Score += GameConstants.BugScore; break; case Type.satelite: Score += GameConstants.SatelliteScore; break; case Type.Saucer: Score += GameConstants.SaucerScore; break; case Type.Spaceship: Score += GameConstants.SpaceshipScore; break; case Type.star: Score += GameConstants.StarScore; break; default: break; } return Score; }//End method [/code] But the score doesn't change. What I forgot? Thx for helping anyway.

albert albert · Answer

Hi Vulpes yes I was already little bit bussy with a switch. Like this: [code] public int ScoreInvader(int Score) { switch (Score) { case Type.Bug: Score += GameConstants.BugScore; break; case Type.satelite: Score += GameConstants.SatelliteScore; break; default: break; } return Score; }//End method [/code]

Vulpes · Answer

This bit of code looks to be where you're setting the score: this.Score = score; this.Score = GameConstants.BugScore; this.Score = GameConstants.SatelliteScore; this.Score = GameConstants.SaucerScore; this.Score = GameConstants.SpaceshipScore; this.Score = GameConstants.StarScore; The last 5 lines need to be replaced by a switch statement which increments this.Score (doesn't overwrite it) with the points for the invader type. You then need to assign the final score back to your 'score' variable: score = this.Score; which is the one you're using to print out the score in this line: g.DrawString(score.ToString() drawfont Brushes.White 10f 15f); Perhaps in this last line you should be using this.Score rather than 'score' as that was just a method parameter?