problem while running for loop.

Question

I designed a windows application form NAVIGATOR and put the following code to the form. When I am passing the parameters string and int to the function Hereitis. e.g if I pass naveen and 1 then It's output must be as: HI naveen HI naveen naveen but in second time or further as per the numberoftimes it always prints HI naveen only. why the value of finalstring is not getting modified each time for loop runs..???? namespace Navigator { class Talker { public static int Hereitis( string thingTosay int numberoftimes) { string finalstring =  HI ; for ( int count = 0; count { finalstring = finalstring + thingTosay + 
; } MessageBox.Show (finalstring); return finalstring.Length; }

Vipul Malhotra · Answer

Sure snapshot below

NAVEEN PANERU · Answer

thanks. you should have told me earlier to use stringbuilder.

NAVEEN PANERU · Answer

If it's working so fine. Then would you please upload the snap shot giving the following output. HI naveen HI naveen naveen HI naveen naveen and so on.....

NAVEEN PANERU · Answer

I did this still didn't get the desired result.

Nishant Mittal · Answer

What is the issue guys ....its a simple program and working fine :(

Shubham Kumar · Answer

Take a look of this link https://dotnetfiddle.net/zdv2lJ

Vipul Malhotra · Answer

ok try this one as well string finalstring =  HI ; StringBuilder sb = new StringBuilder(); for (int count = 0; count { finalstring = finalstring + thingTosay ; sb.Append(finalstring); //MessageBox.Show(finalstring); } MessageBox.Show(sb.ToString()); return finalstring.Length;

NAVEEN PANERU · Answer

I tried that also.. message box pops up every time the for loop gets executed. but output is same as it was earlier.

NAVEEN PANERU · Answer

no I didn't execute the code you just posted. because I don't want HI before every naveen I just want HI at starting of each line and then naveen naveen so on..

Vipul Malhotra · Answer

I think I got what you expect. Just try one thing - put the MessageBox code line inside the for loop and see the output.

NAVEEN PANERU · Answer

HI Vipul. Please see what you explained that output must be HI naveen naveen. i.e output must be like: HI naveen HI naveen naveen HI naveen naveen naveen but I am not getting this instead I am getting what is shown in the image.

Vipul Malhotra · Answer

I think I got what you expect. Just try one thing - put the MessageBox code line inside the for loop and see the output.

NAVEEN PANERU · Answer

I understand what you are saying. but see I am getting output as shown below. while it must not happen.

Vipul Malhotra · Answer

Hi Initially your string finalstring is Hi  after first loop iteration finalstring is now  Hi naveen. Now after next iteration finalstring would be = finalstring + 
 + naveen i.e. Hi naveen naveen; If you want to output to be Hi naveen Hi naveen the use the below code: namespace Navigator { class Talker { public static int Hereitis( string thingTosay int numberoftimes) { string histring =  HI ; string finalstring = String.Empty; for ( int count = 0; count { finalstring = finalstring + histring + thingTosay + 
; } MessageBox.Show (finalstring); return finalstring.Length; } Thanks

Shubham Kumar · Answer

i am just explain above see the 3rd last post of mine. how your loop working ?

NAVEEN PANERU · Answer

no man. I am saying that my output is like this. HI naveen naveen naveen naveen while it must be like this: HI naveen HI naveen naveen HI naveen naveen naveen and so on...

Shubham Kumar · Answer

you are saying about why is this not is one line i m right? if right its because of new line

NAVEEN PANERU · Answer

Yeah exactly. I was saying the same thing. that at the second run o/p must be = Hi naveen naveen but its not happening here. could you explain why..???

Shubham Kumar · Answer

Hi Naveen think once how loop working. your finalstring getting updated every time when loop occurred.. see like string a=a+b; //ok then loop 1st time print ab 2nd time print string a already have ab from 1st loop so ab + b then abb 3rd time print string a already have abb from 2nd loop so abb + b then abbb and so on...

NAVEEN PANERU · Answer

I didn't get your point. See first time for loop is executed finalstring = HI (initial value) + naveen mean now the value of finalstring = HI naveen if now for loop gets executed the finalstring = HI naveen (updated value) + naveen (thingsTosay)..?? why this is not happening here. May be I am wrong but I need someone clarify my doubt.

NAVEEN PANERU · Answer

I have done that also but I am getting the same output as is attached by Vipul Malhotra in the above reply. I am just confused about finalstring not getting updated. I am always getting this output. HI naveen naveen naveen naveen whatever number of times I am executing it.

Nishant Mittal · Answer

Naveen It's giving proper output HI Yoo Yoo in case I run it two times.........if u will pass 1 as integer value your for loop will run twice as u r using

NAVEEN PANERU · Answer

Hi dear. I am also getting the same output. But I am confused about the execution of for loop. See initial string value is HI now when for loop executed for the first time then finalstring = HI naveen so my question is that why for loop is not taking this updated value of finalstring and giving output as HI naveen naveen in second run.

Nishant Mittal · Answer

Hi Naveen I have tested the same and its working fine. I have passed following inputs Yoo and 2 It give me  HI Yoo
Yoo
Yoo
 as output. One thing I have noticed  when you start a for loop with 0  your condition shold be less than only like for ( int count = 0; count

Vipul Malhotra · Answer

Hi I am not sure why your code is not working. I tried the same code and it worked really fine (see output image attached). Can you please share the complete code of the file.. Thanks Vipul