Query regarding Updating record

Question

I have written procedure for updating country including already exist.

While running the code, if a record is updated it is "showing record updated successfuly" and when another record is updated with the same name in the list record is not updated but the message is showing "record updated successfully". Find the below c# code which I have written

protected void btnSave_Click(object sender, EventArgs e)
{
Country objCountry = new Country();
CountryBAL objCountryBal = new CountryBAL();
objCountry.CountryName = txtCountryName.Text;
objCountry.Status = Convert.ToInt16(ddlStatus.SelectedValue);
if (ViewState["Id"] != null)
{
if (!string.IsNullOrEmpty(ViewState["Id"].ToString()))
{
objCountry.CountryId = Convert.ToInt32(ViewState["Id"]);
bool status = (new CountryBAL().UpdateCountry(objCountry));
if (status == true)
{
BindCountry();
tabErrMess.Visible = true;
lblMessage.Text = "Record Updated Successfully";
txtCountryName.Text = "";
ViewState["Id"] = null;
}
else
{
tabErrMess.Visible = true;
lblMessage.Text = "Updatation Failed";
ImgMsg.Visible = false;
}
}
}

Vulpes · Answer

Yes the new operator has the same precedence as the dot ('.') operator in C# so the line is perfectly valid. It always looks a bit strange to me though so I'd tend to use the brackets for clarity.

Sam Hobbs · Answer

I don't understand the syntax: new CountryBAL().UpdateCountry(objCountry) is it the same as: (new CountryBAL()).UpdateCountry(objCountry) I suppose that the way that syntax is evaluated depends on operator precedence. I don't understand the C# documentation of operator precedence but I assume it says what we expect it to say. I suppose that one cause of my confusion is that C++ syntax is different. So unless any of my comments are relevant to the question for this thread my comments can be ignored.

keerthi · Answer

ALTER PROCEDURE [dbo].[PR_COUNTRY_MST_UPDATE] ( @COUN_ID INT=0 @COUN_NAME VARCHAR(90)=NULL @COUN_STATUS TINYINT=0 ) AS BEGIN IF NOT EXISTS (select 1 from COUNTRY_MST where COUN_NAME=@COUN_NAME) UPDATE COUNTRY_MST SET COUN_NAME=@COUN_NAME COUN_STATUS=@COUN_STATUS COUN_UPDATED_DATE=GETDATE() WHERE COUN_ID=@COUN_ID END

Hemant Kumar · Answer

Hi could you please send me the Stored Procedure .I think in the SP only you need to check the record exists or not .Please refer this links http://stackoverflow.com/questions/639854/tsql-check-if-a-row-exists-otherwise-insert http://stackoverflow.com/questions/3189293/check-if-record-exists-update-if-not-insert-stored-procedure Use if exists to see if the record exists or not: if exists(select * from yourTable where ID = @id) begin // update your data update yourTable set columnOne = @columnOne where ID = @id end else begin // insert data insert into yourTable (@id@columnOne) end Try that.

Vulpes · Answer

As the code is using custom classes it's hard for anyone else to guess what's wrong. All I can deduce is that 'status' must still be true for 'Record Updated Successfully' to be displayed in the label. If this is unexpected behaviour then it may be something to do with the way you're obtaining 'status': bool status = (new CountryBAL().UpdateCountry(objCountry)); where I see that you're creating a new CountryBAL instance each time rather than reusing an existing instance. In fact you're creating an instance of this class objCountryBal earlier in the method but you never use it. objCountry will also be a different object each time the button is clicked even if it has the same CountryName property. This may or may not be significant depending on how the UpdateCountry method works internally.