Error : Data type mismatch in criteria expression. (Using M

Question

hi Developers , when i retrive datas from database i got the following error. OleDb Exception Was Unhandled Data type mismatch in criteria expression. (Using Ms Access db) i don't know what is wrong with my code.below am adding my using code string str = "select AttendanceLogs.*,Shifts.EndTime,Shifts.BeginTime,Shifts.Break1,Shifts.Break1BeginTime,Break1EndTime from AttendanceLogs inner join Shifts on Shifts.ShiftId = AttendanceLogs.ShiftId where AttendanceDate between '" + sDate + "' AND '" +tDate + "' and EmployeeId ='" + edr.GetValue(0) + "'"; OleDbCommand getLogs = new OleDbCommand(str, Conn); OleDbDataReader dr = getLogs.ExecuteReader(); so please suggest me if i done any wron in my code. thanks with Paul.S

Manas Mohapatra · Answer

As per error, it is mostly datatype mismtch when it using filter. So make sure that ShiftId column of Shifts and AttendanceLogs tables refers same data type. Secondly EmployeeId is integer type or chars type. If it integer then it won't work because you are passing EmployeeId as char format. Secondly try to use parameterised query to avoid SQL injction. OleDbCommand cmd = new OleDbCommand("Select * From shifts Where ID = @id and Password = @password", conn); cmd.Parameters.AddWithValue("@id", txtBoxUserName.Text); cmd.Parameters.AddWithValue("@password", txtBoxPassword.Text)

Rafnas T P · Answer

try doing follow red changes string str = "select AttendanceLogs.*,Shifts.EndTime,Shifts.BeginTime,Shifts.Break1, Shifts.Break1BeginTime,Break1EndTime from AttendanceLogs inner join Shifts on Shifts.ShiftId = AttendanceLogs.ShiftId where AttendanceDate between ' ( "+ sDate .ToString() + "' AND '" +tDate .ToString() + ") ' and EmployeeId ='" + edr.GetValue(0 ).ToString() + "'" ;

Paul Rajs · Answer

thanks for all of your valuable reply friends Paul.S Man becomes what he thinks about