how can i remove multiple if statement.?

Question

how can i remove multiple if statement.? eg. if (a==something) { }else if(b== something { } ... ..... like this if multiple of if condtion in program how can i remove it shortes one.

Anil Jha · Answer

class DiscountCalculator { public int CustomerType { get ; set ; } public double CalculateDiscount( double totalSales) { double discount = 0; if (CustomerType == 1) { discount = totalSales * 0.15; } else if (CustomerType == 2) { discount = totalSales * 0.10; } else if (CustomerType == 3) { discount = totalSales * 0.05; } return discount; } } I think above is your code and you want to improve this if-else statement. So you can improve it by using below code. interface IDiscount { double GetDiscount( double totalSales); } class SilverCustomer: IDiscount { public double GetDiscount( double totalSales) { // 10% discount for silver customer return totalSales * 0.10; } } class GoldCustomer: IDiscount { public double GetDiscount( double totalSales) { // 15% discount for gold customer return totalSales * 0.15; } } class NormalCustomer: IDiscount { public double GetDiscount( double totalSales) { // 5% discount for silver customer return totalSales * 0.05; } } class DiscountCalculator { IDiscount _iDiscount; public DiscountCalculator(IDiscount customerType) { this ._iDiscount = customerType; } public double CalculateDiscount( double totalSales) { return _iDiscount.GetDiscount(totalSales); } } class Program { static void Main( string [] args) { DiscountCalculator discountGoldCustomer = new DiscountCalculator( new GoldCustomer()); double discountForGoldCustomer = discountGoldCustomer.CalculateDiscount(1000); Console.WriteLine( Discount for gold customer:  + discountForGoldCustomer); DiscountCalculator discountNormalCustomer = new DiscountCalculator( new NormalCustomer()); double discountForNormalCustomer = discountNormalCustomer.CalculateDiscount(1000); Console.WriteLine( Discount for normal customer:  + discountForNormalCustomer); Console.ReadKey(); } } In new DiscountCalculator class if you want to calculate discount for whatever customer you don't need alter DiscountCalculator class rather you will create new customer class. For example if you want to calculate discount for Platinum customer then you don't need to alter DiscountCalculator class just create PlatinumCustomer class. class PlatinumCustomer:IDiscount { public double GetDiscount( double totalSales) { // 20% discount for platinujm customer return totalSales * 0.20; } } class Program { static void Main( string [] args) { DiscountCalculator discountGoldCustomer = new DiscountCalculator( new GoldCustomer()); double discountForGoldCustomer = discountGoldCustomer.CalculateDiscount(1000); Console.WriteLine( Discount for gold customer:  + discountForGoldCustomer); DiscountCalculator discountNormalCustomer = new DiscountCalculator( new NormalCustomer()); double discountForNormalCustomer = discountNormalCustomer.CalculateDiscount(1000); Console.WriteLine( Discount for normal customer:  + discountForNormalCustomer); DiscountCalculator discountPlatinumCustomer = new DiscountCalculator( new PlatinumCustomer()); double discountForPlatinumCustomer = discountPlatinumCustomer.CalculateDiscount(1000); Console.WriteLine( Discount for platinum customer:  + discountForPlatinumCustomer); Console.ReadKey(); } } In this way we have removed if-else statement.

Anil Jha · Answer

To remove if-else statement in C# you can use ternary operator or switch - case statement. I would suggest you to achieve it using decoulpled architure using Dependency injection.

Sivasankar Gorantla · Answer

Hi - If you have two conditions then go for Ternary operator. - If you have multiple if statements in your code then it is better to convert them into switch statements. switch statement is faster than if statement in many cases. Because it internally implements hashtable for lookups. Thanks Siva

Jamil Moughal · Answer

You can avoid multiple if statements by using Switch statement or ternary operators

Satyaprakash Samantaray · Answer

Use switch case

Vishal Verma · Answer

Simple way -Use switch case. Advanced with few lines of code -Use any pattern suitable to your case .e.g -Strategy pattern

Naveen Bisht · Answer

if I will use switch instead of if the thing is same except performance only I want to remove line of if -else and write a generic code for same

Ibrahim Siddique · Answer

you can use two option one is ternary operator and the second one is Switch case 1. Example : int result = Check () ? 1 : 0 ; 2. Example : switch ( grade ) { case 'A' : Console . WriteLine ( Excellent! ); break ; case 'B' : Console . WriteLine ( Good Job! ); break ; case 'C' : Console . WriteLine ( Well done ); break ; case 'D' : Console . WriteLine ( You passed ); break ; case 'F' : Console . WriteLine ( Better try again ); break ; default : Console . WriteLine ( Invalid grade ); break ; }

Nimish Saxena · Answer

You can use ternary operator. for eg:- var res=a == something?something1:something2 ; this produce same result as if else.

Mani Kandan · Answer

Okay Let's say... public string GetAdvertisementType( string type) { switch (type) { case PS : return Product search ; break ; case SS : return Services search ; break ; case ST : return Scrollable text ; break ; default : return  ; break ; } } Cheers !!!

Ramesh Barik · Answer

You can use switch-statement instade of if. switch is more perfermance tuned. Check this link to know more. https://stackoverflow.com/questions/2158759/case-vs-if-else-if-which-is-more-efficient