how to split string dynamically

Question

Hai Friends i want to dispaly data in textbox like id:111 name:venkat color:green so befor i display only for data like 111 venkat green ................. now i want to display like this id:111 name:venkat color:green here is my code string str2 = ""; string[] strListItems; int intNumItems = comboBox1.Items.Count; strListItems = new string[intNumItems]; for (int i = 0; i < comboBox1.Items.Count; i++) { strListItems[i] = ds.Tables[0].Rows[comboBox1.SelectedIndex][i].ToString(); str2 = str2 + "
 " +strListItems[i]; } textBox1.Text = str2; Please give me any idea. Thanks Venkat.S

Vulpes · Answer

If there are 25 rows in ds.Tables[0] then you will get an index out of range exception because strListItems only has 3 elements. Perhaps what you need is : for (int i = 0; i ; i++) { str2 += strListItems[i] + : + ds.Tables[0].Rows[comboBox1.SelectedIndex][i].ToString() + 
; }

Suthish Nair · Answer

So you need to check the rows count in ds.Tables[0].Rows. Also which must be equal to comboBox1.Items.Count

Venkat S · Answer

i get error below code only str2 += strListItems[i] + : + ds.Tables[0].Rows[comboBox1.SelectedIndex][i].ToString() + 
; the error is indexoutofrange Exception. and my full code is string str2 = ; string[] strListItems = { ds.Tables[0].Columns[1].ToString() ds.Tables[0].Columns[0].ToString() ds.Tables[0].Columns[2].ToString() }; for (int i = 0; i { str2 += strListItems[i] + : + ds.Tables[0].Rows[comboBox1.SelectedIndex][i].ToString() + 
; } textBox1.Text = str2; Please resolve my problem.

Suthish Nair · Answer

change to int intNumItems = comboBox1.Items.Count - 1; and try

Venkat S · Answer

Hi Vulpes thanks for replay befor also i have this error. when i give max 3 records it ll be ok.run succ when i give 25 records then get error like indexoutofrange. what is problem u have any idea . i read xml file and when i chek records its read xml file. ya they can be read from the XML file along with the data. Please share u r ideas to resolve it. Thanks VenkatS

Vulpes · Answer

If you didn't have any errors before adding those lines then the only possible reason is that the names array doesn't have enough elements in it. From what you say it sounds like it should have 25 elements but I've no idea whether they can be read from the XML file along with the data or whether they have to be added 'manually'.

Venkat S · Answer

after added those lines and now i have some errors error:indexoutofrange how to resolve it.my records are in xml file i have 25 records

Vulpes · Answer

Do you mean something like this: string str2 = ; string[] strListItems; int intNumItems = comboBox1.Items.Count; strListItems = new string[intNumItems]; string[] names = new string[]{id name color}; // needs to be intNumItems in this array for (int i = 0; i { strListItems[i] = ds.Tables[0].Rows[comboBox1.SelectedIndex][i].ToString(); str2 = str2 + 
 + names[i] + : + strListItems[i]; } textBox1.Text = str2;