[Solved with Solution]BackgroundWorker/Bitmap drawing slower on Dual Core? Or Widnows 7? pls help me...

Question

Hello I finished my programm and wanted start the big test part. Today I started it on a Windows 7 DualCore machine and my BackgroundWorker is damm slow now! I coded it with a crappy old xp pc and everything works fine. My computer just takes 3 to 4 seconds to render the image The Widnows 7 PC took about 4-5 Minutes!!! WTF? Heres my Code: My BackgroundWorker creates a virtual Bitmap and if it is finished the Bitmap becomes the PictureBox's Background. private void paintInBackground_DoWork(object sender DoWorkEventArgs e) { int w = 390 - 1 h = 390 - 1; bitmap = new Bitmap(w h System.Drawing.Imaging.PixelFormat.Format64bppPArgb); bmpgrafik = Graphics.FromImage(bitmap); bmpgrafik.CompositingMode = CompositingMode.SourceCopy; bmpgrafik.CompositingQuality = CompositingQuality.GammaCorrected; painterflag = false; // Enthält ein Messwert eine Note unter 1 ist etwas schief gelaufen Color notenfarbe = new Color(); try { if (measuredatas != null) { for (int k = 0; k // angegeben. Dadurch ist dieser Punkt eben blasser // Ist unsichtbar angegeben dann geht er erst gar nicht in diese schleife und lässt den Punkt aus { notenfarbe = choosemarkcolor(measuredatas[aktTab][k].Mark); notenfarbe = Color.FromArgb(65 notenfarbe); if (dottype == 0) bmpgrafik.FillRectangle(new SolidBrush(notenfarbe) (int)measuredatas[aktTab][k].CoordX + w / 2 - dotstrength (int)measuredatas[aktTab][k].CoordY * -1 + h / 2 - dotstrength dotstrength * 2 + 1 dotstrength * 3 + 1); else if (dottype == 1) bmpgrafik.FillEllipse(new SolidBrush(notenfarbe) (int)measuredatas[aktTab][k].CoordX + w / 2 - dotstrength (int)measuredatas[aktTab][k].CoordY * -1 + h / 2 - dotstrength (dotstrength * 2 + 1) (dotstrength * 2 + 1)); } for (int i = 0; i { bool imageflag = false; if ((measuredatas[aktTab][i].Theta (measuredatas[aktTab][i].Theta > 10 && measuredatas[aktTab][i].Theta (measuredatas[aktTab][i].Theta > 20 && measuredatas[aktTab][i].Theta (measuredatas[aktTab][i].Theta > 30 && measuredatas[aktTab][i].Theta (measuredatas[aktTab][i].Theta > 40 && measuredatas[aktTab][i].Theta (measuredatas[aktTab][i].Theta > 50 && measuredatas[aktTab][i].Theta (measuredatas[aktTab][i].Theta > 60 && measuredatas[aktTab][i].Theta (measuredatas[aktTab][i].Theta > 70 && measuredatas[aktTab][i].Theta ) { if (// Oben (isPhiSelected[aktTab 0] == true && measuredatas[aktTab][i].Phi >= 90 - categories[aktcat].TopPhi / 2 && measuredatas[aktTab][i].Phi (isPhiSelected[aktTab 1] == true && ((measuredatas[aktTab][i].Phi 90 + categories[aktcat].TopPhi / 2) || (measuredatas[aktTab][i].Phi > categories[aktcat].MiddlePhi / 2 && measuredatas[aktTab][i].Phi // Mitte (isPhiSelected[aktTab 2] == true && ((measuredatas[aktTab][i].Phi >= 360 - categories[aktcat].MiddlePhi / 2 || measuredatas[aktTab][i].Phi (measuredatas[aktTab][i].Phi = 180 - categories[aktcat].MiddlePhi / 2 && measuredatas[aktTab][i].Phi (isPhiSelected[aktTab 2] == true && measuredatas[aktTab][i].Phi == 360) || (isPhiSelected[aktTab 2] == true && measuredatas[aktTab][i].Phi == 0) || // Unten (isPhiSelected[aktTab 3] == true && ((measuredatas[aktTab][i].Phi = 270 + categories[aktcat].BottomPhi / 2) || (measuredatas[aktTab][i].Phi 180 + categories[aktcat].MiddlePhi / 2))) || (isPhiSelected[aktTab 4] == true && measuredatas[aktTab][i].Phi >= 270 - categories[aktcat].BottomPhi / 2 && measuredatas[aktTab][i].Phi { notenfarbe = choosemarkcolor(measuredatas[aktTab][i].Mark); if (dottype == 0 && imageflag == false) bmpgrafik.FillRectangle(new SolidBrush(notenfarbe) (int)measuredatas[aktTab][i].CoordX + w / 2 - dotstrength (int)measuredatas[aktTab][i].CoordY * -1 + h / 2 - dotstrength dotstrength * 2 + 1 dotstrength * 2 + 1); else if (dottype == 1) bmpgrafik.FillEllipse(new SolidBrush(notenfarbe) (int)measuredatas[aktTab][i].CoordX + w / 2 - dotstrength (int)measuredatas[aktTab][i].CoordY * -1 + h / 2 - dotstrength (dotstrength * 2 + 1) (dotstrength * 2 + 1)); } } } } if (showgrid == true) { for (int z = 0; z { bmpgrafik.DrawEllipse(new Pen(new SolidBrush(Color.FromArgb(100 Color.Black)) 1) (imagepreview[aktTab].Width / 16) * z (imagepreview[aktTab].Height / 16) * z imagepreview[aktTab].Width - ((imagepreview[aktTab].Width / 8) * z) - 1 imagepreview[aktTab].Height - ((imagepreview[aktTab].Height / 8) * z) - 1); } //Vertikal Oben bmpgrafik.DrawLine(new Pen(Color.FromArgb(100 Color.Black) 1) w / 2 h / 2 MeasureData.polarToX(80 90 - categories[aktcat].TopPhi / 2) + w / 2 MeasureData.polarToY(80 90 - categories[aktcat].TopPhi / 2) * -1 + h / 2); bmpgrafik.DrawLine(new Pen(Color.FromArgb(100 Color.Black) 1) w / 2 h / 2 MeasureData.polarToX(80 90 + categories[aktcat].TopPhi / 2) + w / 2 MeasureData.polarToY(80 90 + categories[aktcat].TopPhi / 2) * -1 + h / 2); //Horizontal bmpgrafik.DrawLine(new Pen(Color.FromArgb(100 Color.Black) 1) w / 2 h / 2 MeasureData.polarToX(80 360 - categories[aktcat].MiddlePhi / 2) + w / 2 MeasureData.polarToY(80 360 - categories[aktcat].MiddlePhi / 2) * -1 + h / 2); bmpgrafik.DrawLine(new Pen(Color.FromArgb(100 Color.Black) 1) w / 2 h / 2 MeasureData.polarToX(80 0 + categories[aktcat].MiddlePhi / 2) + w / 2 MeasureData.polarToY(80 0 + categories[aktcat].MiddlePhi / 2) * -1 + h / 2); bmpgrafik.DrawLine(new Pen(Color.FromArgb(100 Color.Black) 1) w / 2 h / 2 MeasureData.polarToX(80 180 - categories[aktcat].MiddlePhi / 2) + w / 2 MeasureData.polarToY(80 180 - categories[aktcat].MiddlePhi / 2) * -1 + h / 2); bmpgrafik.DrawLine(new Pen(Color.FromArgb(100 Color.Black) 1) w / 2 h / 2 MeasureData.polarToX(80 180 + categories[aktcat].MiddlePhi / 2) + w / 2 MeasureData.polarToY(80 180 + categories[aktcat].MiddlePhi / 2) * -1 + h / 2); //Vertikal Unten bmpgrafik.DrawLine(new Pen(Color.FromArgb(100 Color.Black) 1) w / 2 h / 2 MeasureData.polarToX(80 270 - categories[aktcat].BottomPhi / 2) + w / 2 MeasureData.polarToY(80 270 - categories[aktcat].BottomPhi / 2) * -1 + h / 2); bmpgrafik.DrawLine(new Pen(Color.FromArgb(100 Color.Black) 1) w / 2 h / 2 MeasureData.polarToX(80 270 + categories[aktcat].BottomPhi / 2) + w / 2 MeasureData.polarToY(80 270 + categories[aktcat].BottomPhi / 2) * -1 + h / 2); } } catch { } } private void paintInBackground_RunWorkerCompleted(object sender RunWorkerCompletedEventArgs e) { // Alles erstmal wieder benutzbar machen tabmeasure.Enabled = true; try { imagepreview[paintertabnumber].Image = bitmap; } catch { } bmpgrafik.Dispose(); try { fillsummary(newMeasure[paintertabnumber].Text); if (markFlag) { string fehlermeldung = ; fehlermeldung += Die Notenmatrix wurde nicht korrekt ausgefüllt. + Environment.NewLine; if (painterflag) fehlermeldung += Environment.NewLine + Dadurch entstanden Berechnungsfehler der Noten. + Environment.NewLine + Bitte korrigieren Sie die Notenmatrix um Berechnungsfehler zu vermeiden.; else fehlermeldung += Dadurch könnten Berechnungsfehler entstanden zu sein.; MessageBox.Show(fehlermeldung Warnung MessageBoxButtons.OK MessageBoxIcon.Warning); } } catch { } if (firststart == true && measurePath.Count > 1) { paintpicture(0); firststart = false; } } If having trouble understanding something pls feel free to ask me. Hope you can help me...

Sascha B · Answer

I could allocate where the problem's area is. It is in the backgroundworker do work method. It has nothing special but a few lines could be the problem I think. Theser are the lines: bitmap = new Bitmap(w h System.Drawing.Imaging.PixelFormat.Format64bppPArgb); bmpgrafik = Graphics.FromImage(bitmap); bmpgrafik.CompositingMode = CompositingMode.SourceCopy; bmpgrafik.CompositingQuality = CompositingQuality.GammaCorrected; Maybe the Pixelformat isn't good? The problem has to be there ... This is my last try. After this I let it go! Edit: Solved!!! It was PixelFormat's fault!!! I took Format64bppPArgb and id didn't worked/ worked very slow! If I use Format32bppArgb it works great!!! But I dunno why :) Anyway it works!!!

Sascha B · Answer

It changes nothing! Same speed when I do it without the backgroundworker. Some more ideas?...

Sascha B · Answer

Good question... I'll try it! Just give me time... I'm slow too :) I meant that I can't start the backgroudnworker again if it is still loading. Only if the background isn't working. Hope that clears my weird sentence ...

Frogleg · Answer

What happens if you don't use the backgroundworker - same time ?

Sascha B · Answer

I already try it with this if (!paintInBackground.IsBusy) paintInBackground.RunWorkerAsync(); Didn't I catch that? I thought with this the backgroundworker can't handle 2 things at the same time. I also dispose the graphic after every drawing. Should I dispose the bistmaptoo if it was already drawn and it has to be redrawn? Thank you Frogleg

Frogleg · Answer

Make sure you don't have multiple threads running That is check that your not creating the bitmap twice

Sascha B · Answer

That's what I tested too. :) But now in my code (first post) I created the bitmap first (not in the paint method!) and then I set it to the background. If you do this like me it won't be drawn line by line. So I think it doesn't make any difference. If I'm wrong please correct me.

Frogleg · Answer

As a test I created an image in paint and created an image at runtime and they both load in about the same time The runtime image is created by drawing single pixels line by line till the bitmap is created

Suthish Nair · Answer

refer msdn thread might give any idea.

Sascha B · Answer

That's one solution I have already tried :) I created the bitmap saved it to harddisc and load it as picturebox's background. But it was just a bit slower than my current method. But I will try it once more because of this problem. But a few minutes ago I discovered a very interesting thing on the windows 7 machines. While it was loading we opened the taskmanager and my programm displays a part of the image that has to be shown at once! Means (just a guessing): The virtual bitmap creation works well on both OS. But when the bitmap has to be set to the picturebox's background it slows down and this is the part where the programm takes so long to load on windows 7. I mean these lines try { imagepreview[paintertabnumber].Image = bitmap; } catch { } bmpgrafik.Dispose();

Frogleg · Answer

I don't think it's the graphic card more to do with the code doing the drawing Go over your code again and see if you can optimize it You are calculating and drawing 30000 pixels one at a time. If the images are not dynamic - meaning they don't change - maybe you can save them to disk and load them that way

Sascha B · Answer

No the graphics in the ones with XP is devinitively older and not better than the pcs with windows 7.

Sam Hobbs · Answer

Read what I said. Think about it; don't assume you understand it before reading it. I think you misunderstood. Note that I said  crappy old xp single core  because that is what you called it. I don't know how else to refer to it. You say that it  has a Geforce FX5500 inside . I assume that is a good graphics board. That is consistent with what I said. So listen to me. Is the graphics in the older system better than the graphics in the newer system? I hope that is clear enough; I don't know how to make it more clear. You asked for theories of why the graphics would be faster in an old system and my theory is that the older system is actually a newer system. Is the graphics in the old system newer?

Sascha B · Answer

My crappy old pc has a Geforce FX5500 inside... I don't think that hardware is causing the problem. I've now tested it on 6 PCs 3 XP PCs = working perfectly 3 Windows 7 PCs = really slow loading Is it maybe a .net framework problem?

Sam Hobbs · Answer

Have you looked at hardware acceleration? I think Frogleg is much more experienced with graphics than I am but I know that hardware can do some of the things that Windows does and it depends on the hardware whether or not the hardware can help. So perhaps the crappy old xp single core has a prettier newer graphics board.

Sascha B · Answer

Thats truely an other point. Because of this I'm going to test this on several pcs. So that I can exclude some things

Frogleg · Answer

Maybe there is another program running in the background that slows your program down

Sascha B · Answer

It is already the compiled one. I try to get some other PCs here. And test it there. Try to add some info if I have some new ones.

Frogleg · Answer

Another thought Go into the debug folder and run the exe from there and see if it is any faster

Sascha B · Answer

Yes that's true... I thought someone knows this problem. Or got some OS/MultiCore trouble. Thank you anyway

Frogleg · Answer

Well it should be as fast if not faster -but without trying it myself I'm only guessing

Sascha B · Answer

No sry I can't... pls understand... There isn't that much that is done around this. But I'm sure the things that I can't show you have nothing to do with the slow rendering. What I can additional say are these things: The paint method is called after I calculate my 28.800 marks and everything. So every intensive array math is done before the painting starts. If I start painting I lock my Tabcontrol so nothing can happen during painting. When I start painting I call the backgroundworker who does only these steps: paintertabnumber = tabnummer; // the number where the image has to be drawn tabmeasure.Enabled = false; //locking the tabcontrol if (!paintInBackground.IsBusy) paintInBackground.RunWorkerAsync(); // start the paintmethod above Have you any idea why this is slower on a Windows 7 dua core machin than on a crappy old xp single core one? Have I used a method that is a known issue on windows 7? Or is there a problem with the backgroudnworker and dua core? ... Thanks

Frogleg · Answer

Can you upload your project

Sascha B · Answer

My browser crashed 3 times while I wanted to reply... Anyway... Thanks for taking the time Frogleg again :) I attached an image. Hope it can help you to understand what is drawn. The image represents 28.800 marks Every mark (1-5) gets a different color pink-darkblue So before I drew this image I have done the calculation already. So that can't be th problem. Edit: Every mark is one dot on the image. And I have several configuration methods to change what has to be drawn. Thats because it looks so confusing. It is confusing me anyway :D

Frogleg · Answer

Can you upload an image of what you are trying to create -there seems a lot of code just to draw a bitmap