SQL INSERT ERROR

Question

I use some textboxes and the SQL INSERT command to fill an Access mdb database. But if someone of the textboxes is empty i get an error. What is going on?

helcon · Answer

With the single quotes it's working fine. Thanks to all!

miker · Answer

One more suggestion: use OleDbParameter.

miker · Answer

2 AW: I don't think myTextBox.Text may be null. 2 Constantine: Add single quotes like this: string insSQL = "INSERT INTO [tblNames] (city, email, workfax, workemail) "+ "VALUES ('" + City.Text + "','" + Email.Text + "','" + Fax.Text + "','" + Workemail.Text +"')" ;

Andrzej Wegierski · Answer

Instead myTextBox.Text use: (myTextBox.Text==null?"":myTextBox.Text)

helcon · Answer

private void btnInsert_Click(object sender, System.EventArgs e) { int rv = 0; string conString = "Provider = Microsoft.Jet.OLEDB.4.0;" + "User Id=; Password=;" + @"Data Source=Names.mdb"; OleDbConnection conBase = null; string insSQL = "INSERT INTO [tblNames] (city, email, workfax, workemail) "+ "VALUES (" + City.Text + "," + Email.Text + "," + Fax.Text + "," + Workemail.Text +")" ; try { conBase = new OleDbConnection(conString); OleDbCommand comm = new OleDbCommand(insSQL, conBase); conBase.Open(); rv = comm.ExecuteNonQuery(); } catch (OleDbException m) { MessageBox.Show (m.ToString()); } // City, Email, Fax, Workemail are textboxes. } conBase = new OleDbConnection(conString); OleDbCommand comm = new OleDbCommand(insSQL, conBase); conBase.Open(); rv = comm.ExecuteNonQuery(); } catch (OleDbException m) { MessageBox.Show (m.ToString()); }

Carlos Sanchez · Answer

Can u post some code?

Andrzej Wegierski · Answer

If You concatenate null to insert string You get null string. Check for nulls and add zero length string instead, I think

SQL INSERT ERROR

steven_yin

kovan