Sql Stored Procedure

Question

Can someone help me consolidate this procedure into robust way. The procedure is working. I want to rewrite to make it readable for other developers. Select EmployeeNumber Hours PTO StartDate EndDate PreviousHours INTO #FinalPayPeriodTable From #TempAggregatedTable Select EmployeeNumber ((Hours - (Hours - 80)) - PreviousHours - PTO) AdjHours Hours as OrgHours PTO StartDate EndDate PreviousHours From #FinalPayPeriodTable Set @hours = (Select ((Hours - (Hours - 80)) - PreviousHours - PTO) AdjHours From #FinalPayPeriodTable) RETURN @hours

Francis · Answer

What is the exact error message? If the select query in the set statement returns more than one row it will also throw error. Give me a try: -- combine the 2 select query in one select query Select EmployeeNumber Hours  ((Hours - (Hours - 80)) - PreviousHours - PTO) AdjHours PTO StartDate EndDate PreviousHours INTO #FinalPayPeriodTable From #TempAggregatedTable; -- I have changed with your old code here Set @hours = (Select ((Hours - (Hours - 80)) - PreviousHours - PTO)AdjHours From #FinalPayPeriodTable); -- return it RETURN @hours;

Francis · Answer

Try this: -- combine the 2 select query in one select query Select EmployeeNumber Hours  ((Hours - (Hours - 80)) - PreviousHours - PTO) AdjHours PTO StartDate EndDate PreviousHours INTO #FinalPayPeriodTable From #TempAggregatedTable; -- select the AdjHours column from #FinalPeriodTable Set @hours = (Select AdjHours From #FinalPayPeriodTable); -- return it RETURN @hours; Let me know your thoughts! Hope this helps!

David Smith · Answer

It says already voted

Francis · Answer

Yes I mark the answer. Could you check my last question i posted No. :) If you marked the anything in answer means Accepted lable available. Refer the below thread(Check my reply) http://www.c-sharpcorner.com/forums/thread/329201/how-can-make-Asp-Net-website-responsive.aspx

David Smith · Answer

Yes I mark the answer. Could you check my last question i posted.

Francis · Answer

I just gave you credit Are you sure? I hope you didn't mark any reply as answer. ;)

David Smith · Answer

Thanks for your help. I just gave you credit

Francis · Answer

Happy to knew that your problem solved. If my solution helps you accept that one as answer. :)

David Smith · Answer

I havent tried new code yet. But it just have a red line under the AdjHours field like its not recognizing it. However when it hit check mark or.execute command it saids successful

David Smith · Answer

The set line before tbe return. The AdjHours is not recognized. It has a redline

Francis · Answer

What i have suggested worked fine. In which line you got the error?

David Smith · Answer

I get the red line that the Adjust hours is not recognized. Select EmployeeNumber Hours PTO StartDate EndDate PreviousHours INTO #FinalPayPeriodTable From #TempAggregatedTable Select EmployeeNumber ((Hours - (Hours - 80)) - PreviousHours - PTO) AdjHours Hours as OrgHours PTO StartDate EndDate PreviousHours From #FinalPayPeriodTable Set @hours = (Select AdjHours From #FinalPayPeriodTable) RETURN @hours

David Smith · Answer

I get the red line that the Adjust hours is not recognized. Select EmployeeNumber Hours PTO StartDate EndDate PreviousHours INTO #FinalPayPeriodTable From #TempAggregatedTable Select EmployeeNumber ((Hours - (Hours - 80)) - PreviousHours - PTO) AdjHours Hours as OrgHours PTO StartDate EndDate PreviousHours From #FinalPayPeriodTable Set @hours = (Select AdjHours From #FinalPayPeriodTable) RETURN @hours