Weapon Array for First Person Shooter

Question

Would someone please review my Array for a weapon? Is this the proper construction of an array? If not please correct me..

//Weapon Array

// WeaponName
string[] WeaponName;
WeaponName = new string["M1911"]

// WeaponDescription
string[] WeaponDescription;
WeaponDescription = new string["A moderately powerful handgun."]

// WeaponSubClass
string[] WeaponSubClass;
WeaponSubClass = new string["Sidearm"]

// WeaponROF
int[] WeaponROF;
WeaponROF = new int[1];
WeaponROF[0] = 1;

// WeaponAccuracy
int[] WeaponAccuracy;
WeaponAccuracy = new int[1];
WeaponAccuracy[0] = 80;

// WeaponWeight
int[] WeaponWeight;
WeaponWeight = new int[1];
WeaponWeight[0] = 1105;

// BarrelLength
int[] BarrelLength;
BarrelLength = new int[1];
BarrelLength[0] = 127

// CurrentClipSize
int[] CurrentClipSize;
CurrentClipSize = new int[1];
CurrentClipSize[0] = 7;

// MaxClipSize
int[] ClipSize;
ClipSize = new int[1];
ClipSize[0] = 7;

// MaxAmmo
int[] MaxAmmo;
MaxAmmo = new int[1];
MaxAmmo[0] = 21;

// MaxClips
int[] MaxClips;
MaxClips = new int[1];
MaxClips[0] = 2;

// ReloadTime
int[] ClipSize;
ClipSize = new int[1];
ClipSize[0] = ;

Vulpes · Answer

Well I suppose you could create a Dictionary of string arrays: var weapons = Dict (); weapons.Add(Name WeaponName); weapons.Add(Description WeaponDescription); weapons.Add(SubClass WeaponsSubClass); weapons.Add(Type WeaponType); Console.WriteLine(weapons[Name][22]); // Desert Eagle but it doesn't really achieve anything as you still have to initialize the arrays in the first place and accessing elements via a dictionary lookup is of course slower than accessing them directly.

Suthish Nair · Answer

Why can't we use a Collection like this? List Weapon = new List string string string >(); or any other ways? Edit: I hate this editor...

Vulpes · Answer

Well it's a bit long-winded but OK apart from the two opening statements of each block which should be terminated with semi-colons: string[] WeaponName ; WeaponName = new string[23] ;

Matt · Answer

Thanks very much for the reply. How does this look? public class WeaponClass string[] WeaponName WeaponName = new string[23] WeaponName[0] = M1911; WeaponName[1] = Thompson; WeaponName[2] = AK-47; WeaponName[3] = AKS-74U; WeaponName[4] = M4; WeaponName[5] = MP5K; WeaponName[6] = MG-42; WeaponName[7] = P90; WeaponName[8] = MP-40; WeaponName[9] = Springfield; WeaponName[10] = Arisaka; WeaponName[11] = Mosin Nagant; WeaponName[12] = Dragonov; WeaponName[13] = SCAR-H; WeaponName[14] = Browning M1919; WeaponName[15] = PPSH-41; WeaponName[16] = G-16; WeaponName[17] = P99; WeaponName[18] = TEC-9; WeaponName[19] = Luger; WeaponName[20] = FAL; WeaponName[21] = FAMAS; WeaponName[22] = Desert Eagle; // magnum // //Weapon Description string[] WeaponDescription WeaponDescription = new string[23] WeaponDescription[0] = A moderately powerful handgun; WeaponDescription[1] = A powerful submachine gun from WW2; WeaponDescription[2] = A fairly powerful assault rifle; WeaponDescription[3] = A similar weapon to the AK47; WeaponDescription[4] = A weapon used in the war on terrorist and a powerful assault rifle; WeaponDescription[5] = A modern submachine gun that's accurate and powerful but short range; WeaponDescription[6] = A deployable machine gun used in WW2 with a huge mag capacity; WeaponDescription[7] = A submachinegun of good clipsize accuracy and power; WeaponDescription[8] = The Germans submachine gun in ww2 accurate and powerful but lots of hammer; WeaponDescription[9] = An Allied weapon of WW2 and a good sniper rifle; WeaponDescription[10] = A Pacific weapon of WW2 and a good sniper rifle; WeaponDescription[11] = A powerful and accurate sniper rifle; WeaponDescription[12] = Another accurate sniper rifle with long range;; WeaponDescription[13] = A powerful assault rifle of modern day; WeaponDescription[14] = Another Browning assault rifle with a large mag cap; WeaponDescription[15] = A russian smg with a high rate of fire and good clip size; WeaponDescription[16] = A full automatic pistol with a good clip size; very reliable; WeaponDescription[17] = A moderately powerful pistol; WeaponDescription[18] = A good mag cap and a high rate of fire; an smg; WeaponDescription[19] = A German handgun from WW2; WeaponDescription[20] = An accurate modern assault rifle; WeaponDescription[21] = Another accurate modern assault rifle; WeaponDescription[22] = A powerful short range pistol; // WeaponSubClass string[] WeaponSubClass WeaponSubClass = new string[23] WeaponSubClass[0] = Handgun; WeaponSubClass[1] = Secondary; WeaponSubClass[2] = Primary; WeaponSubClass[3] = Primary; WeaponSubClass[4] = Primary; WeaponSubClass[5] = Secondary; WeaponSubClass[6] = Primary; WeaponSubClass[7] = Secondary; WeaponSubClass[8] = Secondary; WeaponSubClass[9] = Primary; WeaponSubClass[10] = Primary; WeaponSubClass[11] = Primary; WeaponSubClass[12] = Primary; WeaponSubClass[13] = Primary; WeaponSubClass[14] = Primary; WeaponSubClass[15] = Secondary; WeaponSubClass[16] = Handgun; WeaponSubClass[17] = Handgun; WeaponSubClass[18] = Secondary; WeaponSubClass[19] = Handgun; WeaponSubClass[20] = Primary; WeaponSubClass[21] = Primary; WeaponSubClass[22] = Handgun; //WeaponType string[] WeaponType WeaponType = new string[23] WeaponType[0] = Pistol; WeaponType[1] = Submachine Gun; WeaponType[2] = Assault Rifle; WeaponType[3] = Assault Rifle; WeaponType[4] = Assault Rifle; WeaponType[5] = Submachine Gun; WeaponType[6] = Machine Gun; WeaponType[7] = Submachine Gun; WeaponType[8] = Submachine Gun; WeaponType[9] = Sniper Rifle; WeaponType[10] = Sniper Rifle; WeaponType[11] = Sniper Rifle; WeaponType[12] = Sniper Rifle; WeaponType[13] = Assualt Rifle; WeaponType[14] = Machine Gun; WeaponType[15] = Submachine Gun; WeaponType[16] = Pistol; WeaponType[17] = Pistol; WeaponType[18] = Submachine Gun; WeaponType[19] = Pistol;

Vulpes · Answer

If you're intending them to be string arrays with a single element then the first three should be: // WeaponName string[] WeaponName; WeaponName = new string[1]; WeaponName[0] = M1911; // WeaponDescription string[] WeaponDescription; WeaponDescription = new string[1]; WeaponDescription[0] = A moderately powerful handgun.; // WeaponSubClass string[] WeaponSubClass; WeaponSubClass = new string[1]; WeaponSubClass[0] = Sidearm; Also for the final int array if you're going to assign the only element a value (it will be zero by default) then you have to specify the value: // ReloadTime int[] ClipSize; ClipSize = new int[1]; ClipSize[0] = 1; // say It's also possible to shorten these declarations to one line. For example: // WeaponName string[] WeaponName = {M1911}; // ReloadTime int[] ClipSize = {1}; The compiler then deduces that there's only only one element and sets it to the value you specify between the { }.