Wrong Type of Argument

Question

I have next function GetData( CasCadingDropDownList.spGETCOUNTRIES  cur_countries  new OracleParameter ( pContinentId  ddlContinents.SelectedValue)); pcontinentid is number Defining GetData: private DataSet GetData( string spName string crsName OracleParameter spParameter) I add in source cmd.Parameters.Add(spParameter).Direction = ParameterDirection .Input; But my type of spParameter is wrong! How can i change this?

Vulpes · Answer

It looks like you've added the parameters in the wrong order. The input parameter should be added first and the output parameter second.

andreas domevscek · Answer

I also have call to another procedure without parameter in program This works but when i do with parameter it crashes procedure spGetCountries (pContinentId in number cur_countries out t_cursor) is begin open cur_countries for select Countryid CountryName from tblCountries where continentid = pContinentId; end;

Vulpes · Answer

Can you post the first few lines of the stored procedure please. We must be missing something here with the parameter types.

andreas domevscek · Answer

Still same error. protected void ddlContinents_SelectedIndexChanged(object sender EventArgs e) { if (ddlContinents.SelectedIndex == 0) { ddlCountries.SelectedIndex = 0; ddlCountries.Enabled = false; ddlCities.SelectedIndex = 0; ddlCities.Enabled = false; } else { ddlCountries.Enabled = true; decimal temp = Convert.ToDecimal(ddlContinents.SelectedValue); ddlCountries.DataSource = GetData(CasCadingDropDownList.spGETCOUNTRIES cur_countries new OracleParameter(pContinentId new OracleDecimal(temp))); ddlCountries.DataBind(); ListItem liCountry = new ListItem(Select country -1); ddlCountries.Items.Insert(0 liCountry); ddlCities.SelectedIndex = 0; ddlCities.Enabled = false; } } Then i have private DataSet GetData(string spName string crsName OracleParameter spParameter) { string CS = ConfigurationManager.ConnectionStrings[OraAspNetConString].ConnectionString; using (OracleConnection con = new OracleConnection(CS)) { OracleCommand cmd = new OracleCommand(spName con); cmd.CommandType = CommandType.StoredProcedure; DataSet ds = new DataSet(); OracleDataAdapter da = new OracleDataAdapter(); cmd.Parameters.Add(crsName OracleDbType.RefCursor).Direction = ParameterDirection.Output; if (spParameter != null) { cmd.Parameters.Add(spParameter).Direction = ParameterDirection.Input; } da.SelectCommand = cmd; da.Fill(ds); AT THIS LINE OCCURS ERROR return (ds); } }

Vulpes · Answer

I've just checked the ODP.NET documentation and the OracleDecimal type is the exact equivalent of the database's number type. So I'd try this: using Oracle.DataAccess.Types; // ... decimal temp = Convert.ToDecimal(ddlContinents.SelectedValue); DataSet ds = GetData(CasCadingDropDownList.spGETCOUNTRIES cur_countries new OracleParameter (pContinentId new OracleDecimal(temp));

andreas domevscek · Answer

thx Still doesn't work

Vulpes · Answer

Oracle's 'number' data type is similar in concept to C#'s 'decimal' type. So I'd try Convert.ToDecimal rather than Convert.ToInt32.

andreas domevscek · Answer

I Changed new OracleParameter ( pContinentId  Convert .ToInt32(ddlContinents.SelectedValue))) but still doesn't work same error Perhaps error is in if (spParameter != null ) { cmd.Parameters.Add(spParameter).Direction = ParameterDirection .Input; }

Wim Sturkenboom · Answer

Not familiar with Oracle. But ddlContinents.SelectedValue is a string; and Oracle might really want an integer. You can use one of the below int i; i = Convert.ToInt32(yourstring); i = Int32.Parse(yourstring); Int32.TryParse(yourstring out i); For the last one you need to check the return value of the method to check if the parsing was successful. For the first two you need a try/catch block to handle possible errors (in case the selected value is not an integer.